Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180714063904.GH20451@kroah.com>
References: <20180714055816.223754-1-toddpoynor@gmail.com> <20180714055816.223754-14-toddpoynor@gmail.com>
 <20180714063904.GH20451@kroah.com>
From:   Todd Poynor <toddpoynor@gmail.com>
Date:   Mon, 16 Jul 2018 14:28:24 -0700
Message-ID: <CAO3upoaJ8R9svW1kTOu6aGdRpPzjM0i6+YL0YV29xCDwvgSqjA@mail.gmail.com>
Subject: Re: [PATCH 13/18] staging: gasket: gasket_enable_dev fixups
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Rob Springer <rspringer@google.com>,
        John Joseph <jnjoseph@google.com>,
        Ben Chan <benchan@chromium.org>, devel@driverdev.osuosl.org,
        Zhongze Hu <frankhu@chromium.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Simon Que <sque@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Todd Poynor <toddpoynor@google.com>,
        Dmitry Torokhov <dtor@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 13, 2018 at 11:39 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Jul 13, 2018 at 10:58:11PM -0700, Todd Poynor wrote:
>> From: Todd Poynor <toddpoynor@google.com>
>>
>> Remove unnecessary variable.
>>
>> Bail out if no physical device.
>>
>> Signed-off-by: Todd Poynor <toddpoynor@google.com>
>> ---
>>  drivers/staging/gasket/gasket_core.c | 19 ++++++-------------
>>  1 file changed, 6 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
>> index 65aa7cf454fb..f7d8f66e8746 100644
>> --- a/drivers/staging/gasket/gasket_core.c
>> +++ b/drivers/staging/gasket/gasket_core.c
>> @@ -915,8 +915,6 @@ static int gasket_enable_dev(
>>  {
>>       int tbl_idx;
>>       int ret;
>> -     bool has_dma_ops;
>> -     struct device *ddev;
>>       const struct gasket_driver_desc *driver_desc =
>>               internal_desc->driver_desc;
>>
>> @@ -934,26 +932,21 @@ static int gasket_enable_dev(
>>               return ret;
>>       }
>>
>> -     has_dma_ops = true;
>> +     if (!gasket_dev->pci_dev) {
>> +             gasket_log_error(gasket_dev,
>> +                              "%s: no physical device", __func__);
>> +             return -ENODEV;
>> +     }
>
> How can this ever be true?  I don't see where this can be removed to
> enable this error check to be hit.  What am I missing?

Agree, I'll split this into two patches for the two things it does,
and just remove the unnecessary check.  Thanks,

>
> thanks,
>
> greg k-h


-- 
Todd