Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3227957imm; Tue, 17 Jul 2018 00:52:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd9YUgBpyBVoJW03eHAJpxI8/hv+LEGxJ4VXofJEg2MVTN5nujZv/V8yLBh/YVRVaG854Ex X-Received: by 2002:a62:404e:: with SMTP id n75-v6mr600619pfa.232.1531813973262; Tue, 17 Jul 2018 00:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531813973; cv=none; d=google.com; s=arc-20160816; b=jmgTsgqz+8ynlDYq47sih5PVajQCcCF0Ko3hssbvNDjzBbwLvy5w985ccTJjNFEj+j BThdsxY9GESv97uWk3AIibQ/TDZjnUeGazpCl9FW4qyOLfqwvl02C18RUtAfr4uulhdB dHM08Tpw4o0YYublvnRYB2gJrZ1jatwXpIf0TLKK/WYLAbFcljPOhzQpf8MjM9OaYxA3 g9AlmfsAltTVZl3EUly46ok0mc/lRg1CH+Wbi815nblL7VVKPU8VMkbGQDxPJAAeDh7n WPVDBylz//dFOyjcHr97dGCCUdfCn1EAcY1thkO7/WY/S6cHPdM2OkSAAsizEBFtU4jm YJkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=isLcyJ6ZMUKfoHpbgraVkGeJjNSNrIMUQKcMnv55czY=; b=IXLYZV5Fdjn4pqxmJPa7Y87PXlg6zEX9Hs80AygtkL2YMg5Ttm+M1Epkz54MxXSAo3 RX66raI4Y9vMLW+ayoDdo5e6vTrm//NryeES/ThtsCLiUQ8SHAMXjCOIiAYNUO97tn/J lbNVNCdPAYDcCVwidBEitzVrWWPxj5KQf5rq7YEwnhJMx4shi/mcDT31R+rC3Z1tWJfo Za6kqd2YgH5zkRV50h3sKm7WEsSwfNBjqtd0u5FYp7c33Kgde88HZHw1IhyuJq4MwUcf ao2NkVp0BGVvXcjgC0SNkR60yEKAT3+caDsjAcPYj1SXv7FYcj62gMdHF41ON4DFZQ/m eW+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si278975plk.397.2018.07.17.00.52.38; Tue, 17 Jul 2018 00:52:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729621AbeGQIW4 (ORCPT + 99 others); Tue, 17 Jul 2018 04:22:56 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:54104 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbeGQIW4 (ORCPT ); Tue, 17 Jul 2018 04:22:56 -0400 Received: from hsi-kbw-5-158-153-52.hsi19.kabel-badenwuerttemberg.de ([5.158.153.52] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ffKll-0002DB-Us; Tue, 17 Jul 2018 09:51:38 +0200 Date: Tue, 17 Jul 2018 09:51:37 +0200 (CEST) From: Thomas Gleixner To: RAGHU Halharvi cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] genirq:Dereference desc after null pointer check In-Reply-To: <20180716230309.23937-1-raghuhack78@gmail.com> Message-ID: References: <20180716222725.14896-1-raghuhack78@gmail.com> <20180716230309.23937-1-raghuhack78@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jul 2018, RAGHU Halharvi wrote: > * Remove unchecked dereferencing of *desc & assigning it local irq > variable > * Move the assignement after proper check of *desc for NULL pointer. Sorry no. The NULL pointer check is pointless because the call sites already do it before calling that function. Thanks, tglx