Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3246493imm; Tue, 17 Jul 2018 01:16:14 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdbkYMJ2NfbQjU8icB6XkCD0Ux2aB+/nrFZX8PLtf93auncGjWf2Vi8SkV7bN4HVJun/3j8 X-Received: by 2002:a65:48cd:: with SMTP id o13-v6mr597702pgs.99.1531815374873; Tue, 17 Jul 2018 01:16:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531815374; cv=none; d=google.com; s=arc-20160816; b=pmtI5OVzgqffjQEljQ4r2f/ywjFEifrQXnYIseqSxjMijvfA+oOCvGUxQsWIEgBsNc JLtb2sRYmQB3OwUZQeCZnxiUJ4v7gz+rs91m+cEqKHl3sgNreFXyQ0IuqjqF5Gbng09s tqLpTNaHSKQbapC1qciPlsJpgCMRgXvYLrDPYrgYGjbWT0AZhXzGrhKyhw8lvYjnRzTp soB4unAQyQ9adfSgTh9YwTIXKKjMEbu7uiQT/H8V16oDddCGid/aZuz1ly2OWYwMsu0Y xhRmbDdVFV5XLXlU3D5liv7ypm4ncUg0RN/svH2vjAmC6FQfxBxPhpuHGObdw1RyPCtO sahA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=J+gstwVCFqlFfgmxoxh72LkjINTd93YeXG+7psn/6k0=; b=kRGtGMp3AP+xUIFEAcs4Q9Z5ANKUF5grWPmmTh4f6D9nzYPLI3Pme519N/+08m8rC1 lWuCaQcKHD7xnoeh5gO+g9am2clqu2a9mdNqydgJjK2o1DR0Xl4ZlJPFf6sxB+jqV5aH Cnw88ASmPtwopxyuaGACWxSbS0Bmuzd6mKBBn2AZk1eQm754aLFRH/uRkoLyO6s9wxW/ s5F+MDPdye3iAwaujut9yn5fHB+CFkE06t1rLxaF/Kzt/7Ue5a+hM4AnVdXEvIBCx1vt AcE91xD1YEGbVGWoEn3ZO5Ip2jMqBM1hr3cEr+34xNnIXini1A4Ufk4RjZqWoiokieZG valw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Ccdf6mPO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1-v6si343235pfi.369.2018.07.17.01.16.00; Tue, 17 Jul 2018 01:16:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Ccdf6mPO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729989AbeGQIqg (ORCPT + 99 others); Tue, 17 Jul 2018 04:46:36 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42012 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbeGQIqg (ORCPT ); Tue, 17 Jul 2018 04:46:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=J+gstwVCFqlFfgmxoxh72LkjINTd93YeXG+7psn/6k0=; b=Ccdf6mPOrV211mcPKW8Jld0CC AYIqIq7I1TaQUWgW3trJjkrz+xo6EX5w3oTIs3OwAvhDSXf5jaEknIP7kER2Qvy/AaEoDTwAezJRL DdkfKaugZmv8V2O6aL6npbGvJIvN9NYjAdEYtojD5uz1EaFgBMak9mYwFgHiiyJ0yw4adCO5MH2gv imEtdq9czUwZsb++gDPgXLHxugBXwiHTleINvTwQTDNcEZ1lzk5+Ud0cWrMwm84v2JruLbShT4OuY +lsh9zIZshM3pyLz/IX9CS0AHJ33uo6x7fq5M4Updlz3oNeF+GZ7Fonn02Tz0n1DSoOEhSgJL4i1O Iu+sUAfTg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1ffL8Y-0002tl-CV; Tue, 17 Jul 2018 08:15:10 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E9F8A20275F36; Tue, 17 Jul 2018 10:15:07 +0200 (CEST) Date: Tue, 17 Jul 2018 10:15:07 +0200 From: Peter Zijlstra To: Andreas Herrmann Cc: "Rafael J. Wysocki" , Frederic Weisbecker , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Commit 554c8aa8ecad causing severe performance degression with pcc-cpufreq Message-ID: <20180717081507.GS2476@hirez.programming.kicks-ass.net> References: <20180717065048.74mmgk4t5utjaa6a@suselix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180717065048.74mmgk4t5utjaa6a@suselix> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 08:50:48AM +0200, Andreas Herrmann wrote: > I've recently noticed that commit 554c8aa8ecad ("sched: idle: Select > idle state before stopping the tick") causes severe performance drop > for systems using pcc-cpufreq driver. Depending on the number of CPUs > the system might be almost unusable. Have you looked at that driver? It features a global lock which is taken for all cpufreq operations. Once you get past a handful of cpus that will constrict your system exactly as you say. What kind of machine are you running this on, and can you configure the thing to use anything else? If so, do so and never look back.