Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3348888imm; Tue, 17 Jul 2018 03:21:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfpRGuo9E+3VW2oZvWQblrEjiAGCG4BTt3fArPyCJaxBNuX1wgLT4orSVAu6uDgplJX7QmE X-Received: by 2002:a63:d15:: with SMTP id c21-v6mr1038849pgl.322.1531822914534; Tue, 17 Jul 2018 03:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531822914; cv=none; d=google.com; s=arc-20160816; b=wPit2xFTgI8Fs8KZzQgXMPVP4gdFI9byVDTH1Ketr0RzvA/VgI9GBnljezOmjm4KXB 7m6WuZ7K4MR4nKw7grQ4IUm5Nt2VFiI2TErRJzcVt+TSrGIjSqmlz2BTZcDVgTBE7GXO mDWhcJnP391if/YAdXZ5+ZWeOTX7HCAUJR0jk6SuimV9pI9Ir3wnxGx6XAJrK7hmgx92 8Y5ULkMucrio9SfeJ3pEtU2p3uu7r5RxsjqX9mw7ibCO+P9t8uVZ36q2OqSXGMU5HWyF H9ztAjp0XtQ01YH8jQjb1ayn2jPagx1KSpIXRHIzT5SEkB0NgwQco6Utfqvpfx0JZcqr BUcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=5fHudnLgNIpYde+yFGqLpc8kWsTXeNZDx2IvqSqOkGU=; b=ebfoxq4VrG+BTz2pIk8uy0IZqNRIENmQbz+KmzOSlmgts1C5fH0Jg9j2nbXsA4VT8T tgTFhiX364oxfG8Pw46Da6UGCZgdOXFQ+JypF/FW1I5tGkKCAcU9FkM34ent2m2Svvdl TISuVpZMw99TyBV9PESJkrnVV6Oor3VlLqsQ8jXVA+myHrBWkucF6wyPs50Nj2OcZ5Sp 8zN1jpY6pM0jd5kT4GUyqRFvkW6AvUoWup6w5XAbeLjQPoSUV75Bp4US+JRdzHKQ0oDO TEd3IHvz7haGDFhNrOfC0iwoQQeX6Pc+YOs1QvmHMFmHCVuquyDeFlSqHDChIlL5RGsT iFyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WWOpxPZc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t16-v6si477802pgu.487.2018.07.17.03.21.39; Tue, 17 Jul 2018 03:21:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WWOpxPZc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730093AbeGQKwM (ORCPT + 99 others); Tue, 17 Jul 2018 06:52:12 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46147 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729717AbeGQKwM (ORCPT ); Tue, 17 Jul 2018 06:52:12 -0400 Received: by mail-pg1-f196.google.com with SMTP id p23-v6so244767pgv.13 for ; Tue, 17 Jul 2018 03:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5fHudnLgNIpYde+yFGqLpc8kWsTXeNZDx2IvqSqOkGU=; b=WWOpxPZc9JQT/DJk/6pamBYaGnL1O4J0SDiLSrMSyE3FU8fXM3xbPV6C9BqbpJzDzq oQTD+YQ+74VaujYx1A9LYdRZT0BPjF+R5er14QOh+shB3jSliOVMdZWl01AQkD0X7i2X NVAUCVZu/hyejzX4VV+25Qh+xJgYhBLU0hDsaTdckFI+SghM8yDWsULzrsTMBu9YP52f 4sF9W9SxG4B2OZQuJSAPdd0z8A+YQhu3m2eX9cVshnl2aQWs8g5+bWLukbx47IUQxKz8 3geVsInwMHYFGheS0QM2l8wQEYZEPt4MvF2hyVQr9Zw/mGzykvjAWA/TlYkNR44iO1sc k98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5fHudnLgNIpYde+yFGqLpc8kWsTXeNZDx2IvqSqOkGU=; b=aioSxYs4H5HJ8s01tAKBqDTwADgGPS3VdGYJ4GVQpOs4bBubdr02+NZycEOvoehgcd m/FdRPLZrygmXxk19+3HcVCF1/EIq0tVkynDfqUq4J2nnDbbiaBIihKRU9nhlDMtsjyb Fylz86NtfWsZBQirQ1Yp/Cy5uyX1hkcgUrEvvLMUXZ5WLiWFA8AQFCVZ8onYH0xf3B8U 83Knt02ekXxpW5d+7xJGomNSpVRe/KpWFElcFBhyrC0JRJ0PaZ1KfWcfP6iL4ajMyn00 WouC3HfN6y/cG3MsURUp3VNgQjQR2lbR8T2Y48gK98B64N8SPo/pxl8nFFoiqhqoDjQo GRfA== X-Gm-Message-State: AOUpUlHHGpCjD8KJ/LXnvNDLnfQf8lND2EeUKzk0cbBmoU8q35lIWgOD eWxEMyvzxMDRNLOOxkeMfDEug/MU X-Received: by 2002:a62:444d:: with SMTP id r74-v6mr77780pfa.96.1531822818106; Tue, 17 Jul 2018 03:20:18 -0700 (PDT) Received: from raghu-VirtualBox ([116.197.184.12]) by smtp.gmail.com with ESMTPSA id h24-v6sm2976073pfk.113.2018.07.17.03.20.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 03:20:17 -0700 (PDT) From: RAGHU Halharvi To: linux-kernel@vger.kernel.org Cc: RAGHU Halharvi , tglx@linutronix.de Subject: [PATCH] genirq:free_irq:remove redundant null ptr check Date: Tue, 17 Jul 2018 15:50:09 +0530 Message-Id: <20180717102009.7708-1-raghuhack78@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Remove the misleading null pointer check in __free_irq, its redundant because the callee checks before calling __free_irq. Signed-off-by: RAGHU Halharvi --- kernel/irq/manage.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index facfecfc543c..7246f6c7f702 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1563,9 +1563,6 @@ static struct irqaction *__free_irq(struct irq_desc *desc, void *dev_id) WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); - if (!desc) - return NULL; - mutex_lock(&desc->request_mutex); chip_bus_lock(desc); raw_spin_lock_irqsave(&desc->lock, flags); -- 2.17.1