Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3359544imm; Tue, 17 Jul 2018 03:34:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfJEs8nkS7n5+MYVLtmR7aLP/16yauERkNFbd8PgOObngAqL2y1bO6rOOs2RGDL3PoYtTPX X-Received: by 2002:a17:902:e005:: with SMTP id ca5-v6mr1092645plb.224.1531823680012; Tue, 17 Jul 2018 03:34:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531823679; cv=none; d=google.com; s=arc-20160816; b=gJxHCIxUh5Q46+ThrycDJysEFbcxM5Hs0Ach0ryRqjt+m5I53uy72teo3OJymSMKBU 5sZ5MuJtAMMmfqHPAiK3qvzhZSVMus2FZABm/wKVl8zqFlUDdVxg8pAc1Bzl2d8pr3Jy CT3ok1UX4Kqqa2ZkOcZOCD8wH1T/pI+wMOFFoHqMf6olfZCAnosYrUkImWxed2asoJNI o0ZxMgO4AtnG82dHCfbfu25Em7cn0dAVMO1v6ZX5bRLP8TVVGtmaHUB/KwM0ps99nn5I UFOJnJ4GinDd7/XRVLWFCeCmOGBB1n9Q3WewcAWOJOHMSNI6aNB9fxrzH6gYCfl0zNO6 dP1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=pASW+aokpJgN6t/t2VKcVuc0qz3VLUjTmcUKP1bVqzA=; b=ndK8LX45EzozYlCkIMc8TbjC0afEgZeaX3IAahjr5IF86Wn9Tc2nuqIZzVGWLR2Uti 3JTW/imSVhEJ2+M9mPBZCWkf2q54genuwGwd6TUCaIA4UvTXgBneJa7enBXIaaHRiBz0 Zb/WhDc0KDHvu+m9aHQHW2ae2u/Faukusvy/y5S0RXK1W0LQJUSS5HaONc+fKWKWDkfc H9WQ/UQI0RHuB1J5RdasuG5QnEyKI4n77bMYflbobSHr5bJpwQKHBnG31TOc5VFV7v3G 5gofRa3NeTLayIPj/WgF9C+Qpa7JpL5J4TvLya3kBfoLr7aKkWTJU3v1yFNRcP0VsJd5 v0sQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=marvell.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3-v6si540112plb.478.2018.07.17.03.34.25; Tue, 17 Jul 2018 03:34:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730878AbeGQLFk (ORCPT + 99 others); Tue, 17 Jul 2018 07:05:40 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:44234 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729717AbeGQLFk (ORCPT ); Tue, 17 Jul 2018 07:05:40 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6HATtVo030146; Tue, 17 Jul 2018 03:33:38 -0700 Received: from il-exch02.marvell.com ([199.203.130.102]) by mx0a-0016f401.pphosted.com with ESMTP id 2k7ehm9555-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 17 Jul 2018 03:33:38 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by IL-EXCH02.marvell.com (10.4.102.221) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 17 Jul 2018 13:33:34 +0300 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Tue, 17 Jul 2018 03:33:33 -0700 Received: from hannah.il.marvell.com (unknown [10.4.50.2]) by maili.marvell.com (Postfix) with ESMTP id BC0D93F703F; Tue, 17 Jul 2018 02:58:14 -0700 (PDT) From: To: , , CC: , , , , , , Hanna Hawa Subject: [PATCH 2/5] dmaengine: mv_xor_v2: kill the tasklets upon exit Date: Tue, 17 Jul 2018 13:30:00 +0300 Message-ID: <1531823403-3683-3-git-send-email-hannah@marvell.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1531823403-3683-1-git-send-email-hannah@marvell.com> References: <1531823403-3683-1-git-send-email-hannah@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-17_03:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=380 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807170109 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hanna Hawa The mv_xor_v2 driver uses a tasklet, initialized during the probe() routine. However, it forgets to cleanup the tasklet using tasklet_kill() function during the remove() routine, which this patch fixes. This prevents the tasklet from potentially running after the module has been removed. Fixes: 19a340b1a820 ("dmaengine: mv_xor_v2: new driver") Signed-off-by: Hanna Hawa Reviewed-by: Thomas Petazzoni --- drivers/dma/mv_xor_v2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index e16083a..e718498 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -903,6 +903,8 @@ static int mv_xor_v2_remove(struct platform_device *pdev) platform_msi_domain_free_irqs(&pdev->dev); + tasklet_kill(&xor_dev->irq_tasklet); + clk_disable_unprepare(xor_dev->clk); return 0; -- 1.9.1