Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3446374imm; Tue, 17 Jul 2018 05:07:33 -0700 (PDT) X-Google-Smtp-Source: AAOMgpekJc8dRJumqM/n+TD5NGE1CN6P+cbMr/xp2GfaerSWerAcGfpAZ0aRKMoKVQy3sp69GybZ X-Received: by 2002:a62:3856:: with SMTP id f83-v6mr445545pfa.48.1531829253728; Tue, 17 Jul 2018 05:07:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531829253; cv=none; d=google.com; s=arc-20160816; b=f3wSZINi5O6pMWfd9zOm/N32dzxn8US6Qyk6RmYqW2Ml6m1Mtzcx4b54C/Z7uFSCoP JGTqhzAmr+VqnhbigSTMHs30EjecyDazSHLN3tbE/+xYBl2L9eH8TOlPoysIaFlWmAME q+qVUCp4uS+JmeEbNLIgenEy7nYA4zNOlZ4yJVKtiYPWNUj6Zd4znaONelQ4Ns6GjYx7 g9Tm4mn6aa+0Osd1AN76VjeLDmNq5tAH3z1LqdmgZ0KSRq+OzuvbGdnx7dQ05H0N8Qwm IHwkYFk9DKoeLeJSm7VyoXfW2TUZY4My0CvjqQzycfherBC4OiG+gtiqv78PHPBKsA3M 3Wgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=ZpA6K+CHXs0h/hfU8hcGiB7lprfK/b3I20WZX9HufpY=; b=BHpa6myexNnYdhEacRR7NPer0xb3TC5LrxPPQRilQ3Q2/98MR/b7XtWx2HsMl66Jv4 TW9kLLvJhrazhejWZVK/g0liqW0p9ZwCBvlEiD4uuhvjltXQ9DcC2aKLzfhnwWD36sA9 CC8d9FIaxEqjRyZbiXRNXHpWDa1kDWVqKHKDZWpQpHTkuIMV8yooNNfFNZ9LW0rEnrme Rhab7EhwDLQwPQUHkkMtspbGsfH1IoObEGYXrGmCweCyrzcSdej0AAGKmDPu47L9E5x9 wiZLw1RifCdLhfwCllUCSU4tGGcvR/AzoMjysrmvq8RUTdGFytfaM/QKOgfCQidBHPlY nEow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hpEkUYoX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m39-v6si735874plg.371.2018.07.17.05.07.15; Tue, 17 Jul 2018 05:07:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hpEkUYoX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731269AbeGQMjB (ORCPT + 99 others); Tue, 17 Jul 2018 08:39:01 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36253 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729508AbeGQMjA (ORCPT ); Tue, 17 Jul 2018 08:39:00 -0400 Received: by mail-pg1-f195.google.com with SMTP id m19-v6so358615pgv.3; Tue, 17 Jul 2018 05:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZpA6K+CHXs0h/hfU8hcGiB7lprfK/b3I20WZX9HufpY=; b=hpEkUYoXVIqwX/Twz8fhyPec7i1xQD8/UZj5Jt2s6VjsudoE0ZDes+ukOXWpO1nuyw DTE/YPcBEaWgO5iOYoLeq7DkiOXjpMsTPdFS9gQhVx9aPWHoRDWCxQNRTo+JpDNNCODU DxjdjKmnXn5yvh2MuTTibkJpur2lS9J3j9M4SiEpSs1TQPhEHGiIff314gqxloiOLK/3 4U8muqK/ZxhDL4cXj4/88W1yaIlDj4pDqSDpXEz0DiRdhSAlSPZtCsr+t77wl9w5R6ja /JMnCj1uL2iloqapaMIu0zlXZbzbNPHFzMZBn//cVE8Ui4agwE9xveQ1RqlIdpT+ZY5A 0Z2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZpA6K+CHXs0h/hfU8hcGiB7lprfK/b3I20WZX9HufpY=; b=n0FDjexMP4z318ZlVAjYwDe4a1CjLa3X9owGqL+S01uIHzPMWZqVo4+uHZmEJBYHj0 lhWxJSWyQU1P1zgLhVXVRpyNS5WKF3cpjLJo39nNtkdRS+ya1wjtNu+2WCvjeghxS/E4 qBql1UoOzOHhIv1UdIIaHgQ/zlhiAL8vHu4dgGGYzMDaXWQVZ/5eccVrXpDEy2wjJQPy MMrDWmFDEL+mlg3rTbUC+8SEDvRslctjbGnHVl74Lg4MJWr+VTJALspTXXaCeMyp0UwL spb48SSt7Y3PNLDau29AjrRSAImDFdJFTN8MurCzM3c5Uhc+6wONuOrsnbTlMNhBYsKH 6KLg== X-Gm-Message-State: AOUpUlG2d+6huJH4KW67KyN84YQWGGKJZfEO/3nDWp4d20OKGXqnNyrX edPXgVPmLRpTaq7NC5QPyv4= X-Received: by 2002:a63:f953:: with SMTP id q19-v6mr1314826pgk.292.1531829200651; Tue, 17 Jul 2018 05:06:40 -0700 (PDT) Received: from raghu-VirtualBox ([116.197.184.12]) by smtp.gmail.com with ESMTPSA id j75-v6sm3290327pfj.102.2018.07.17.05.06.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 05:06:39 -0700 (PDT) From: RAGHU Halharvi To: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Cc: RAGHU Halharvi , marcel@holtmann.org, johan.hedberg@gmail.com Subject: [PATCH] Bluetooth:hci_bcm:Check return value from devm_clk_get Date: Tue, 17 Jul 2018 17:36:35 +0530 Message-Id: <20180717120635.25259-1-raghuhack78@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <5b4ddae5.1c69fb81.61055.042e.GMRIR@mx.google.com> References: <5b4ddae5.1c69fb81.61055.042e.GMRIR@mx.google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Check return value from devm_clk_get & return appropriate error. --- drivers/bluetooth/hci_bcm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index 441f5e1deb11..1295cc89d702 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -910,6 +910,8 @@ static int bcm_get_resources(struct bcm_device *dev) return 0; dev->clk = devm_clk_get(dev->dev, NULL); + if (IS_ERR(dev->clk)) + return PTR_ERR(dev->clk); dev->device_wakeup = devm_gpiod_get_optional(dev->dev, "device-wakeup", GPIOD_OUT_LOW); -- 2.17.1