Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3488450imm; Tue, 17 Jul 2018 05:49:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeXkwDuoLmTqnk8boag5K3QR0T4ZG+x4KnqwoNnxRZdg5odCGialiuHIi+5pzDb0kVrgUMr X-Received: by 2002:a63:1b5c:: with SMTP id b28-v6mr1516645pgm.204.1531831740659; Tue, 17 Jul 2018 05:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531831740; cv=none; d=google.com; s=arc-20160816; b=Vf7ezGtSWMYXjLYCVZ1u3hHH7aRs+ej3FM5bBs69dnScZqYlDpIRd06Ak44jb1HHnZ D101S/t+1QvtLcWF2jYi5Wxwt9+NHqilU+6Cxc2j3ta11pOm9rz6azP7EVowTpVu0Laa QwJLhETxG/IfMnvjbZxnc1VFYFg1ZKGbvu9ed96rvg9miQkewEe3OjC65kCHZ/wG0Pk4 bT1itnmP6o3YTMbwKF8IAUUJtiT9qB8f2VF3ZNPoluQL9kbpv5VYmdNaW6pIQIDgw0BK SvBZ6lt6xKNaoX7zNrs0JJZvJFpbDfjRO1do6lokVqH39W0obPURdcIPbFFMcmm47PXw jKaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=CV9gNk7Z8x6g/8WvnlnNhrxVMaGHub/tohmjMdnY3fk=; b=ZOdk6WsBg/4liW9mB0ClT8fVqyawixBxNQ7LKiNWlxwsYexNxODn5iFfvdTMYcHg1s S4DbOFKKGUgKS/lw6ySeV9m/sSpC7Azb1yuJtSx25XrHOrJFKRwrGfBr241dLGTUxG2x ebLnUvKtVgdHnX4pbZ7aIpCTco2OJJyM5oRZQuvJRoQL5kDxmpHg3Pt7Ar6AS6LnvWgb 0TYkNpHy/gpbjzHTpz9yWXYYMPKjUurzq3RgBV4xyWrwzh7duPvj0CZouwrCFVB4w8Ut onzSABvJBAok9arVIIRtA8DboOgkA8oaCk5+x9LsqN/1oV4Q7bqyJmP7oFjX2EGgpRzd kwBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si862601pgn.143.2018.07.17.05.48.45; Tue, 17 Jul 2018 05:49:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731661AbeGQNTk (ORCPT + 99 others); Tue, 17 Jul 2018 09:19:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:55216 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731481AbeGQNTj (ORCPT ); Tue, 17 Jul 2018 09:19:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 96A2AAD3C; Tue, 17 Jul 2018 12:47:07 +0000 (UTC) Date: Tue, 17 Jul 2018 14:47:03 +0200 From: Michal Hocko To: Richard Weinberger Cc: LKML , Artem Bityutskiy , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Theodore Ts'o , Andreas Dilger , Steven Whitehouse , Bob Peterson , Trond Myklebust , Anna Schumaker , Adrian Hunter , Philippe Ombredanne , Kate Stewart , Mikulas Patocka , linux-mtd@lists.infradead.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: vmalloc with GFP_NOFS Message-ID: <20180717124703.GA30926@dhcp22.suse.cz> References: <20180424162712.GL17484@dhcp22.suse.cz> <3732370.1623zxSvNg@blindfold> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3732370.1623zxSvNg@blindfold> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 24-04-18 21:03:43, Richard Weinberger wrote: > Am Dienstag, 24. April 2018, 18:27:12 CEST schrieb Michal Hocko: > > fs/ubifs/debug.c > > This one is just for debugging. > So, preallocating + locking would not hurt much. > > > fs/ubifs/lprops.c > > Ditto. > > > fs/ubifs/lpt_commit.c > > Here we use it also only in debugging mode and in one case for > fatal error reporting. > No hot paths. > > > fs/ubifs/orphan.c > > Also only for debugging. > Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. > I can prepare a patch. Hi Richard, I have just got back to this and noticed that the vmalloc NOFS usage is still there. Do you have any plans to push changes to remove it? -- Michal Hocko SUSE Labs