Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3588940imm; Tue, 17 Jul 2018 07:17:33 -0700 (PDT) X-Google-Smtp-Source: AAOMgpecMID3S0s/FfOxW/LCYsXTMSwC47YR0hlUGH1C6fFnbDp7YHkDJvJQJIGExKr+06JmdPXg X-Received: by 2002:a63:81c3:: with SMTP id t186-v6mr1795724pgd.413.1531837053538; Tue, 17 Jul 2018 07:17:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531837053; cv=none; d=google.com; s=arc-20160816; b=mn/U6VgCGt8FMa3NJcfdSuplht/XPeswZcE0LnqhTivQ1NTSeVu79F1rKk7hnFiW1q MjzIME7pf05x/aZbOAxogGos4g5LlV1CynMLKb2q2bOf7pJMph1m//8wMPqrjxiDfcsi 6+QVGDg/TnYMANVWah7nR2M63TXz03AqmvWC64E79hKHVWpUaZ2KN/Sj6r7jIyaW++/Z T8g2xNtAaqyhN3qya1WQ13zGzk/zAcPu98+tx5XKzqIeSLz4BQuJGtPyIcbcGlkWIbBW 5Ne6mrI17PWR3r/3HRRsnfQNgBdOfSHWr76/fK4X4PUI59qv5Rj8VHkMZ8t3gvap3UKC JNng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ZZ4KndFwA3KV+5BHpYSUDzvyMA6B/8tFlNACiFPkc7g=; b=JQKZs9e0bhGDZr5T8I74C1QUXfL7YeIzZaLxWMJgJCZTnjFuaH5PGea40Hb3Aceu2P wyPevYCC8smwlfkVn1tQBZjbUV4QKJyUpcPmtLLud1gqx+nEXpRFVKvAPgXILpD1Co56 ARz80U7OotxcEK04z9JjA3SURsvbNkI6+i323NFA3o4+bZpmGycQLbKeJJCqPAYK7YDH F0Oamnwk+5zFfT84RA+JAWCEl4V/w3rgKf/kgpARmiEQG2OecLJFUhhOx3osTNibTA9O 7Ad9xVAMFH8hWTz01LFSj/zrpyro/UUkvDnoVKQCIJt+F1wzS2NcPh0FcPhgNq8mdX6o hthg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Qf5bl8Fz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9-v6si1086168pfg.27.2018.07.17.07.17.18; Tue, 17 Jul 2018 07:17:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Qf5bl8Fz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731830AbeGQOtZ (ORCPT + 99 others); Tue, 17 Jul 2018 10:49:25 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42440 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729035AbeGQOtZ (ORCPT ); Tue, 17 Jul 2018 10:49:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZZ4KndFwA3KV+5BHpYSUDzvyMA6B/8tFlNACiFPkc7g=; b=Qf5bl8Fz6G4a0Y75MfuqgChYz gdlrC8C6MboDlATZLjH5AFTU9gZo9cGrVAmv6ZUubf8rvlF8MlnX7+vNtdKbV9CHjgs9HsfOwfYL3 BltAZ6Yi8BOf5ZjDAOKXWhKLol7opLAo7orHOtGjrYa12uFdjoMAyFT5LJoryhNBK2F9QXxeblnUO XpbQeeBdv3drUPUC2sSWtkQqig+3siASQckpfU/gz673w5dcd6ckOtSIIOLoBEN+YJBVwEhd0X9H5 wElNFOTB7rPo4le5KqWhsR3zcjcPhbfsGgF6+Ur80RoDbbwkLpkXqBP/+tk8fBE28omgiyhQISGIN 7ekCoPpAg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1ffQlz-0000no-RD; Tue, 17 Jul 2018 14:16:16 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 44BDE20275F36; Tue, 17 Jul 2018 16:16:14 +0200 (CEST) Date: Tue, 17 Jul 2018 16:16:14 +0200 From: Peter Zijlstra To: Johannes Weiner Cc: Ingo Molnar , Andrew Morton , Linus Torvalds , Tejun Heo , Suren Baghdasaryan , Vinayak Menon , Christopher Lameter , Mike Galbraith , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 08/10] psi: pressure stall information for CPU, memory, and IO Message-ID: <20180717141614.GE2494@hirez.programming.kicks-ass.net> References: <20180712172942.10094-1-hannes@cmpxchg.org> <20180712172942.10094-9-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180712172942.10094-9-hannes@cmpxchg.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 12, 2018 at 01:29:40PM -0400, Johannes Weiner wrote: > +/* Tracked task states */ > +enum psi_task_count { > + NR_RUNNING, > + NR_IOWAIT, > + NR_MEMSTALL, > + NR_PSI_TASK_COUNTS, > +}; > +/* Resources that workloads could be stalled on */ > +enum psi_res { > + PSI_CPU, > + PSI_MEM, > + PSI_IO, > + NR_PSI_RESOURCES, > +}; These two have mem and iowait in different order. It really doesn't matter, but my brain stumbled.