Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3595195imm; Tue, 17 Jul 2018 07:23:00 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdJsIIzth7aEQdYvdaxMPv3Ec1omgdtaNjAhfN0F8s+M2UrR5vnpq+HIj35sI1slCRWE53m X-Received: by 2002:a17:902:760d:: with SMTP id k13-v6mr1849026pll.56.1531837380090; Tue, 17 Jul 2018 07:23:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531837380; cv=none; d=google.com; s=arc-20160816; b=lpeb1sV2dypY1c1iJcQ9lSlWJtZNpcuje2rVZfyhtvCrRuseQRcX5Sh1sbXX2NnJkK wCQwcz9a29pNGz8laVV2i0/j/pDIrpmra1OqZp65tFV8ulx4+6b/iMiJQ3SjlTlQQ33Z K54wLTbB86ztZuJL8hldBJKtaLHhOeIcUqXGR8LWuqrzN5Icb7Y8XbLpMFJo0GsSAnDN pPE0Fz6xzucsHEj+NHNs7ltsL/7U570nbisuwFwQtDoESv/CpKbzyl+mPNh6ZSpp/x57 8YjY/sDHVSGrk7Q2u7VkYWOdA5I8KY51UMC3n/lgU2Om2w0nUIAqAo6rd1BnrRMDrjFO A/nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=URfz+q4h4k97tsGxpDxOj+XFQg85S2tsvcdSOhbgsDo=; b=ASlxMnnSehKIfchGLTL0JISSF7hmtYEWsJpCWh1+AQdjjMyWKEkb1o1XokDnqExxfb 4YLnv6RSIcrDK8S9Wdvan2UWDc/jpSxw3s+oRnVbeg2+DTPHqWK/jzYPxcE3B2l/gQYQ OLmRG07Y+Fp/Roz4qaKS4NHD94Il21WeKORXttqxc8mUCZi/TQ19Gts0bGvP3MA6EAu0 oP13IjrIEzzcudoo/C55SNlB5fsFlhftTeJOJJduplRhFO9TO6GqTq63Piwl/SpnqFQH 7yZJzAvw8YoUKrHTtacP1eIVXQwzV9feNsPTBF61o8tQbkhZvHZLNJUAtPATDKZzs6BJ ezEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11-v6si1241911plm.143.2018.07.17.07.22.45; Tue, 17 Jul 2018 07:23:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731864AbeGQOy7 (ORCPT + 99 others); Tue, 17 Jul 2018 10:54:59 -0400 Received: from verein.lst.de ([213.95.11.211]:51658 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731733AbeGQOy7 (ORCPT ); Tue, 17 Jul 2018 10:54:59 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id BD5596FC87; Tue, 17 Jul 2018 16:24:37 +0200 (CEST) Date: Tue, 17 Jul 2018 16:24:37 +0200 From: Christoph Hellwig To: Davidlohr Bueso Cc: Christoph Hellwig , Ingo Molnar , Peter Zijlstra , Andrew Morton , Al Viro , Andrea Arcangeli , Mike Rapoport , Jason Baron , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: waitqueue lockdep annotation V3 Message-ID: <20180717142437.GA20286@lst.de> References: <20171214152344.6880-1-hch@lst.de> <20180712191753.fvk2qersdvhcoqzp@linux-r8p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180712191753.fvk2qersdvhcoqzp@linux-r8p5> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 12, 2018 at 12:17:53PM -0700, Davidlohr Bueso wrote: > On Thu, 14 Dec 2017, Christoph Hellwig wrote: > >> Hi all, >> >> this series adds a strategic lockdep_assert_held to __wake_up_common >> to ensure callers really do hold the wait_queue_head lock when calling >> the unlocked wake_up variants. It turns out epoll did not do this >> for a fairly common path (hit all the time by systemd during bootup), >> so the second patch fixed this instance as well. > > I ran into these changes because of patch 1 getting rid of ep->lock. Is > there any reason why this series was never picked up? I'd love to see this merged, but I never heard back about it.