Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3631655imm; Tue, 17 Jul 2018 07:56:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfL7YY5Y50dSIkfBZ1TwSpHDjGVUgaDGgRM8YfxGaZ+jL82hpxyEkRTlQ71LiD+ldQb0buh X-Received: by 2002:a63:4857:: with SMTP id x23-v6mr1985397pgk.30.1531839391986; Tue, 17 Jul 2018 07:56:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531839391; cv=none; d=google.com; s=arc-20160816; b=PjZj8Oc3l86qnsvIK1c/d3Co1h6Um3wk4Lmtqz3xCVlhPWuekM0VjHs9RaFwwDRzhd FuoNKeigb39fpMid9GITjQAeb0Ci/Wik9cadhWhqiMsv+0120TGbd1+e00qdp6HtWQ08 LjwHpauoiqPsOByymerMlzqnlqsqFs3kF1heZ6NrLdPwgWfvcS4463uoL+i4fVh3D1hY UhNLilX7sj22AMHAw1MhaXpocPVm4ymVs73oCaeoC6cxMmbNOcMz8A4NhoezBhJEUPWd Xu7FOxgIC/o3/Amj3ejIhMhMeXFTP+F/qdkvwFmaahaE8iAuKex/e0k0uOVeqPUMe/2Y wGhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=w8lsmq6NeL6PGVGNX3IlfJqEa7iKhzoeryPjLMv8A28=; b=XYfbLYqQ4boklJzlFfXwWjKKQE4sFXpHn6GMwrMYdSoD1QTs4agSQQbHyCxwR0bIv4 EP8lWD+usbrklLNZ7qLCNm7kNkaYXwepzCzMrK7l/qFdkbgW4NmbXNIxQTSZhfk0n+zL eRFamooPX4AreJAwGBwxuUALM+UvrMnO1fbLUC9H3FGMTPJsJerHTxmQHMLfFwEn6vJw TG5ScNpdNKFePYuC+FIZg/0Re5SpZvyp0lWOtg+V9n0HFLPaupDmldxRwKtqHQCevKU4 ZLql7+UAXhZnN9BxGOjwmWU0O7CCyOdfc1n6vr9+2vboQxC4GCbCEoUzfaob/VVo7Ab4 VpBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si993306plc.415.2018.07.17.07.56.17; Tue, 17 Jul 2018 07:56:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731899AbeGQP2f (ORCPT + 99 others); Tue, 17 Jul 2018 11:28:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:53536 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731617AbeGQP2f (ORCPT ); Tue, 17 Jul 2018 11:28:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 263FEAE12; Tue, 17 Jul 2018 14:55:32 +0000 (UTC) From: Coly Li To: linux-kernel@vger.kernel.org Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, Coly Li , Andy Shevchenko , Greg Kroah-Hartman , Linus Torvalds , Thomas Gleixner , Michael Lyle , Kent Overstreet , Kate Stewart Subject: [PATCH v3 0/3] add crc64 calculation as kernel library Date: Tue, 17 Jul 2018 22:55:22 +0800 Message-Id: <20180717145525.50852-1-colyli@suse.de> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch set adds basic implementation of crc64 calculation as Linux kernel library. Since bcache already does crc64 by itself, this patch set also modifies bcache code to use the new crc64 library routine. bcache uses crc64 as storage checksum, if a change of crc lib routines results an inconsistent result, the unmatched checksum may make bcache 'think' the on-disk is corrupted, such change should be avoided or detected as early as possible. Therefore the last patch in this series adds a crc test framework, to check consistency of different calculations. Changelog: v3: Remove little endian restriction and remove 'le' from function names. Fixes all review comments of v2 v2: Combine first two patches into one Fixes all review comments of v1 v1: Initial version. Coly Li Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Linus Torvalds Cc: Thomas Gleixner Cc: Michael Lyle Cc: Kent Overstreet Cc: Kate Stewart --- Andy Shevchenko (1): lib/crc64: add crc64 option to lib/Kconfig Coly Li (3): lib: add crc64 calculation routines bcache: use routines from lib/crc64.c for CRC64 calculation lib/test_crc: Add test cases for crc calculation drivers/md/bcache/bcache.h | 7 +- drivers/md/bcache/btree.c | 2 +- drivers/md/bcache/request.c | 2 +- drivers/md/bcache/super.c | 5 +- drivers/md/bcache/util.c | 131 ---------------------------------- drivers/md/bcache/util.h | 5 +- include/linux/crc64.h | 15 ++++ lib/.gitignore | 2 + lib/Kconfig | 8 +++ lib/Kconfig.debug | 11 +++ lib/Makefile | 12 ++++ lib/crc64.c | 71 +++++++++++++++++++ lib/gen_crc64table.c | 76 ++++++++++++++++++++ lib/test_crc.c | 136 ++++++++++++++++++++++++++++++++++++ 14 files changed, 341 insertions(+), 142 deletions(-) create mode 100644 include/linux/crc64.h create mode 100644 lib/crc64.c create mode 100644 lib/gen_crc64table.c create mode 100644 lib/test_crc.c -- 2.17.1