Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3687233imm; Tue, 17 Jul 2018 08:42:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpecul+apq/oEaJMnP6nsIUTCOIvy/d0AxsIQWrQq1Irm01aAZ+Jmzxu2DkSZPmwvON3Z2/J X-Received: by 2002:a65:550d:: with SMTP id f13-v6mr2145820pgr.340.1531842169527; Tue, 17 Jul 2018 08:42:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531842169; cv=none; d=google.com; s=arc-20160816; b=BRAkjCXU4IZwKoBQuxQ820pyqtjFhiGTm6ecLT9dmpkMcyz/1xdQKCgu429mJQXeVy n4SH97b3xutnMWUM+9CIH8Lha19MSTMWmeYF4vGOyVFFpuHPDeYZzB3SAgmWLxjO0uZ2 adCCaM8NqFnRG7CWUzOSero5Ueifcob0t8+Kdm609WR12wDzZqUiMcJbKajzsC/51KqL A1n+uN5D9OsmzKd/cmuweir607FZSDLJ+JbvmOrszLmonMzH4LRFHHH0mlcZXfzMgipQ oyQHs7VC9qPyp5KscqLnOqldfX+Xe58eMxo592uO1CqewzKCzSTN1WTX6Fl8+S3duzUU cC5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=e5q193k9pL4ulG9JCJmpg6eEXFA1/JPHC9FYkFnCx58=; b=FFFZes6Aste0wxhFohmhG3rZYBt3Sh7kFaSJh8B9nj+URuuqGwIUH2qffI9OjRgNeK cNiAe6sTHjenhHnp4FgYvgfo2uGO7B8vGdCMhXAxOQaCx5DjA2JyH8NG1vTDR3uPtpeS xL823kAhVzHhqw/uPu4Z1Q3DF8QiVmga/5WjJ9OFk8xSIeLrfTBClOVVPiBHmBra9xpi XVYTEpoqdJ9NG66s468ZCdqnELJhe5dX75hbM4fk+09mFFRSCRew2T5byGnTorgR8L9v d53ytrrqRSye9XqWhRRxy8ucs/DR3IvoTVI+L1sPqtYImaI5rzRs0xUNF6Kl6wRw6h74 EQ2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NPV7rvYs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7-v6si1150159plt.4.2018.07.17.08.42.34; Tue, 17 Jul 2018 08:42:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NPV7rvYs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730503AbeGQQOe (ORCPT + 99 others); Tue, 17 Jul 2018 12:14:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:52292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729721AbeGQQOe (ORCPT ); Tue, 17 Jul 2018 12:14:34 -0400 Received: from [10.82.11.232] (unknown [131.107.174.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D4FE20779; Tue, 17 Jul 2018 15:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531842080; bh=KHbbwVhMUX8DNv4TJezF3HTEMpMA04oIf5EKuQIAE/Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NPV7rvYsXYf3fH32ByUTTZwMupl6zXiuyrRcXaUfNJbBzgw27By8LRvhrVgQeWqM5 VTCO2k8rPH62b3Z6YZww0ze9T/h1Q/Ff61RaEuLVxoETGMbNFlIgzcNE3DnZOD4+Dr Ftdo4saibAXmB6NMLz2TGCbBP8kPbS3vXgz5n068= Subject: Re: [PATCH] PCI/AER: Do not clear AER bits if we don't own AER To: Alexandru Gagniuc , bhelgaas@google.com, keith.busch@intel.com Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Frederick Lawler , Oza Pawandeep , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180717153135.25925-1-mr.nuke.me@gmail.com> From: Sinan Kaya Message-ID: <494a5df8-0987-3a6c-30a4-a3c9ef4ed1f3@kernel.org> Date: Tue, 17 Jul 2018 08:41:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180717153135.25925-1-mr.nuke.me@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote: > + if (pcie_aer_get_firmware_first(dev)) > + return -EIO; Can you move this to closer to the caller pci_aer_init()?