Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <f1cc2710-2bd5-4a55-1a40-67cb2f4e0798@nokia.com>
References: <20180717134756.3447762-1-arnd@arndb.de> <f1cc2710-2bd5-4a55-1a40-67cb2f4e0798@nokia.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 17 Jul 2018 18:00:50 +0200
Message-ID: <CAK8P3a2ZnATY2ZgcV6bDz0bxNhvU3FQCJ5RdNVpanmo5CBy6zw@mail.gmail.com>
Subject: Re: [PATCH net-next] net: cavium: add missing PCI dependencies
To:     Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Aleksey Makarov <aleksey.makarov@cavium.com>,
        Radoslaw Biernacki <rad@semihalf.com>,
        Felix Manlunas <felix.manlunas@cavium.com>,
        Sunil Goutham <sgoutham@cavium.com>,
        Vijaya Mohan Guvva <vijaya.guvva@cavium.com>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 17, 2018 at 4:31 PM, Alexander Sverdlin
<alexander.sverdlin@nokia.com> wrote:

>> @@ -35,7 +35,7 @@ config      THUNDER_NIC_BGX
>>       tristate "Thunder MAC interface driver (BGX)"
>>       depends on 64BIT
>>       select PHYLIB
>> -     select MDIO_THUNDER
>> +     select MDIO_THUNDER if PCI
>>       select THUNDER_NIC_RGX
>>       ---help---
>>         This driver supports programming and controlling of MAC
>
> I believe this hunk should look exactly as the previous one, i.e. 64BIT && PCI,
> BGX itself depends on PCI as well.

That would work as well. My approach was to allow compiling that driver
with PCI because I got no build failures other than the MDIO_THUNDER
issues.

> I've actually sent v2 to fix the above, but got no reply on it up to now...

Your patch was applied into net-next already, so you need to send
a fix relative to your first patch rather than a replacement.

      Arnd