Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp69156imm; Tue, 17 Jul 2018 14:09:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd1pWx3JVJRaeooU5rTeiUt1Pya2sshmPCEdn99LGo+WV/GSggQbWwf2kNlY3ocD2YzfAa2 X-Received: by 2002:a63:7454:: with SMTP id e20-v6mr3176574pgn.410.1531861756071; Tue, 17 Jul 2018 14:09:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531861756; cv=none; d=google.com; s=arc-20160816; b=gZpT6QB1kFQAAjihBYB555Ik3Gv5aW+06F6GcOtPx9NkddKqlVLvGlUtMEP4oBorIG StPMyNOrXoS5cq2DEVqyeceTr6cfPPRlpmcteL75jF70hsczvOoO+zNUYmDaUK3Ve8FM AT4mFjI/bhLt/kmgUSRRDiCkU349FVIu/7NQvaGP5DQYxurEkukq5BIbwZ+uJm3ODy2k 2y1xwOSgxS3dgiEZRam2HEIVvfiSKG4VW8me/A2La8Iw0TFPorEfTXAawTd4T+RGtXaN CyjGCVWtCEDdStu/l5PygsIXkResoBRqU+tGRd13FMy/pNl4gLASEjSureIthIcMp0Ru C0Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=6tQthbItpELtx2tcVt6A1Q4NFrs2iYph/zHKnFp+TCE=; b=biZmfWZUKPvxsYTYDyRyfQYhQh2RZyem3V7kGMgYOUeKjtKqCSsrbDOx51Zl1m39CO 6Opvajj+Y+QRLlJJS4U2u7/mxcfyEAuRe9HgBj1RQ6xIiGH9izRJvzfmXczaFtjfPZHK 3/pY5/u4ycG93db16zqcHmyr8jN+uobUuZgZ3wgdNqFQjkaYgEsQxIBEvmorbEzLuD2B cZfbLL05dtShyTxAofb/TYbsbTVyFTEcop/sc0tPLkQ6Tlv9FsLFAyFEV4mciAaC/i3M o0wZN6Ek+LxnNQo7S+umtSvOw91MvbRZYyGDSlP3VTLe7kJZo9sDr0b6cFzGjbfDjgu0 Dnnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d83ML8M+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si1636691plj.216.2018.07.17.14.09.01; Tue, 17 Jul 2018 14:09:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d83ML8M+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731787AbeGQVl4 (ORCPT + 99 others); Tue, 17 Jul 2018 17:41:56 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:41527 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731336AbeGQVlz (ORCPT ); Tue, 17 Jul 2018 17:41:55 -0400 Received: by mail-vk0-f67.google.com with SMTP id j11-v6so1358413vke.8 for ; Tue, 17 Jul 2018 14:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6tQthbItpELtx2tcVt6A1Q4NFrs2iYph/zHKnFp+TCE=; b=d83ML8M+HyZzQZclz4nDfOe8rxYgkWvY6q/dHQAT2Xg3eJ5mY65HtloBvky9OSqsEJ k2JnXjRxUQHom03K50w9BCM7tG6DAC/tZK1SwFodgZ1a5CYPIEmRUR5Lbt70R+5Ut2/p glg0bTuX8U+ifQUi4JLTUOgizditEO6W/cL03m9+0brIMFupU6oKPXiZ7i0NOpvpqJsh smjBXNkYTX1p+9wDbJXsonSZR1kaE3ro+pXBH+3EZ2pl+S9fjx8X0h9crj++XieDqIO/ KGUb7hOR9unmihS6XluSTvQrrsUpJNgeCD3vA2yRVHIJ1xNw3MUXZeJcbYoZhKd8kQRe /YoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6tQthbItpELtx2tcVt6A1Q4NFrs2iYph/zHKnFp+TCE=; b=oHBF+9ktlcCxzPNs5NLfCmCjUL7uG/b4J/GJf/M8oG7Ils4qNXAsre66zXQ35tDqkv tKu8SrcHCjc5UGuMR1qsVLnOcRjnvdAqg0kGbkYbKSotnfGPOjzDkPNW+19Pb8YEPQpW UiXE9nATvr6aoSiqx+IU52dTeHwTrAI4IRpjtlaRPCeCqTMwSvak2Eowx7NvyhVHo0LI LIEJlJ7ej/AcgYNh4Ov5J0tsKnOAZR9mvOjtxg5dh7/ePfv5nZPYy390ME3rJSXKUzQi ZliU/GMHni23EcJ4wX8/kCb8eXHbmyTJHq8Sd9wTgHSDsLn5IbjZBEBwDdji8neZ9g1O 3EFw== X-Gm-Message-State: AOUpUlHIbwfmwVlnEAvvgGfJ/1/EnslQh929PA0nIOtl+15jQSWy9ytJ Skgbr7ZTSHdTe6URfKq2VUCDmcos/UsU8KaKRV5LQA== X-Received: by 2002:a1f:8e4d:: with SMTP id q74-v6mr1984328vkd.161.1531861646996; Tue, 17 Jul 2018 14:07:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:2149:0:0:0:0:0 with HTTP; Tue, 17 Jul 2018 14:07:26 -0700 (PDT) In-Reply-To: <12409dc4-c10a-d77a-f88d-165aa92b489e@rasmusvillemoes.dk> References: <1530943625-3288-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20180707111209.GA27768@gmail.com> <12409dc4-c10a-d77a-f88d-165aa92b489e@rasmusvillemoes.dk> From: Andy Shevchenko Date: Wed, 18 Jul 2018 00:07:26 +0300 Message-ID: Subject: Re: [PATCH] x86: Avoid pr_cont() in show_opcodes() To: Rasmus Villemoes Cc: Tetsuo Handa , Ingo Molnar , Ingo Molnar , Linux Kernel Mailing List , Tetsuo Handa , Andy Lutomirski , Borislav Petkov , Josh Poimboeuf , Linus Torvalds , Peter Zijlstra , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 12:01 PM, Rasmus Villemoes wrote: > + printk("%sCode: %*ph <%02x> %*ph\n", loglvl, Ah, I had looked at this code and thought about %ph, but didn't get through how to split it correctly. Thanks for the hint! P.S. I see the result, pretty nice and doesn't use pr_cont() at all. -- With Best Regards, Andy Shevchenko