Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 17 Jul 2018 18:58:15 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>, tgraf@suug.ch,
        linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>,
        netdev@vger.kernel.org
Subject: Re: [PATCH] lib/rhashtable: consider param->min_size when setting
 initial table size
Message-Id: <20180717185815.20e5662318274aadcf9a9357@linux-foundation.org>
In-Reply-To: <20180717223057.7wdtjwbusxfqpvur@linux-r8p5>
References: <20180714062516.30433-1-dave@stgolabs.net>
        <20180716000046.yscgnpr256qhm2qg@gondor.apana.org.au>
        <20180717223057.7wdtjwbusxfqpvur@linux-r8p5>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 17 Jul 2018 15:30:57 -0700 Davidlohr Bueso <dave@stgolabs.net> wrote:

> On Mon, 16 Jul 2018, Herbert Xu wrote:
> 
> >On Fri, Jul 13, 2018 at 11:25:16PM -0700, Davidlohr Bueso wrote:
> >> rhashtable_init() currently does not take into account the user-passed
> >> min_size parameter unless param->nelem_hint is set as well. As such,
> >> the default size (number of buckets) will always be HASH_DEFAULT_SIZE
> >> even if the smallest allowed size is larger than that. Remediate this
> >> by unconditionally calling into rounded_hashtable_size() and handling
> >> things accordingly.
> >>
> >> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> >
> >Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> >Normally these patches go through netdev so could you please resend
> >it with my ack to netdev@vger.kernel.org?
> 
> So I've done the resend, but at least would think that routing the
> patch through Andrew would work best as he picked up the rhashtable
> changes regarding ipc and this touches the same call.
> 

Either approach works.

Reviewed-by: Andrew Morton <akpm@linux-foundation.org>