Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1531883057.8953.87.camel@mtkswgap22>
Subject: Re: [resend PATCH v4 5/5] drm: mediatek: Omit warning on probe
 defers
From:   Sean Wang <sean.wang@mediatek.com>
To:     <matthias.bgg@kernel.org>
CC:     <ulrich.hecht+renesas@gmail.com>,
        <laurent.pinchart@ideasonboard.com>, <ck.hu@mediatek.com>,
        <p.zabel@pengutronix.de>, <airlied@linux.ie>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <mturquette@baylibre.com>,
        <sboyd@codeaurora.org>, <lee.jones@linaro.org>,
        <davem@davemloft.net>, <gregkh@linuxfoundation.org>,
        <mchehab@kernel.org>, <rdunlap@infradead.org>,
        <pi-cheng.chen@linaro.org>, <linux-clk@vger.kernel.org>,
        <linux@armlinux.org.uk>, <matthias.bgg@gmail.com>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <mbrugger@suse.com>
Date:   Wed, 18 Jul 2018 11:04:17 +0800
In-Reply-To: <20180717220328.792-6-matthias.bgg@kernel.org>
References: <20180717220328.792-1-matthias.bgg@kernel.org>
         <20180717220328.792-6-matthias.bgg@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-07-18 at 00:03 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> It can happen that the clock drivers wasn't probed before the
> ddp driver gets invoked. The driver used to omit a warning
> that the driver failed to get the clocks. Omit this error on
> the defered probe path.
> 

so if we list drm device as a child device of mmsys we don't need the
patch, and that make more sense.

> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Acked-by: CK Hu <ck.hu@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index bafc5c77c4fb..6b399348a2dc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -374,7 +374,8 @@ static int mtk_ddp_probe(struct platform_device *pdev)
>  
>  	ddp->clk = devm_clk_get(dev, NULL);
>  	if (IS_ERR(ddp->clk)) {
> -		dev_err(dev, "Failed to get clock\n");
> +		if (PTR_ERR(ddp->clk) != -EPROBE_DEFER)
> +			dev_err(dev, "Failed to get clock\n");
>  		return PTR_ERR(ddp->clk);
>  	}
>