Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp62125imm; Tue, 17 Jul 2018 20:51:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdITwZ2m380QcGNCMXDzfQNiEKOYFoE/nls/vEOx8EamPe+yh01hTIgwnw5Oh/08jzQng68 X-Received: by 2002:a62:225d:: with SMTP id i90-v6mr3419142pfi.246.1531885911035; Tue, 17 Jul 2018 20:51:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531885910; cv=none; d=google.com; s=arc-20160816; b=kuXidw2X9vm6NrSLTtJk0DrrcK2HD7MxUHXyjYQ653th6hL3x0rQ2jnA2lmAjJP5K3 8Mb7mWbIXp7DwJQZI93SpF8Lqh4ZUmpgucmr+IMA2PCxVJ6Caf0YsuvUP736QWobvi3t HE1VSfM58eQWbxLCVKDrflMaZ3u6LjmpdiLLIf1WiMR1xRVElOTZtNGcxLWaqWcXCMfg Bijc2gi8OdPiY+54AlcKvXK8QQWGWpChNYSwKzg/CQyQC7cubAIzxPq6GkHnJnmCaGik 31sRL5cBwsUFkqDrIIteWKg72uj8FrzHM0DD3jazsSZjpDIf8aVR75Ps6JYnOkjV0oi9 kYTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=nkZcAF62nhN3K6+ldOULgagY1768nEXROglqgLPRTVg=; b=TkPR4764fU1wor73VKZrEne2gUXyWgrI9zcPb3Re5wM0CXvQFuyR1Ffxgcv03zesRZ 9RR18QmFFgRml8MAnRLP+9tt+ecsnfXpEHscWZrGW9nMwh28mlL91/nbhpf47O7BHAFE XEKDm3IGlbF+wFD/P34HmH+/Z5G8+5YesV0vVHF7jz9MZwJGP5ptCQOazS0HzgprOznk +K7+hWSzdNXTbXK0m7YLJBOlVe54q1pnc41Ol/b+7KWMMqI6wVgclNlsVKD68XnTHHid l7ZDjaROoIgkAE6hiEvTosdy8kgb1cHq+y1/QWM8x5KohYqkKSKStg0XJHiE09o554NT clrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12-v6si2279200pld.362.2018.07.17.20.51.35; Tue, 17 Jul 2018 20:51:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbeGREZo (ORCPT + 99 others); Wed, 18 Jul 2018 00:25:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46344 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbeGREZo (ORCPT ); Wed, 18 Jul 2018 00:25:44 -0400 Received: from localhost.localdomain (c-24-4-125-7.hsd1.ca.comcast.net [24.4.125.7]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D66F22D; Wed, 18 Jul 2018 03:49:55 +0000 (UTC) Date: Tue, 17 Jul 2018 20:49:54 -0700 From: Andrew Morton To: William Breathitt Gray Cc: gregkh@linuxfoundation.org, jic23@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, fabrice.gasnier@st.com, benjamin.gaignard@st.com, robh+dt@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, mark.rutland@arm.com Subject: Re: [PATCH v7 01/10] counter: Introduce the Generic Counter interface Message-Id: <20180717204954.4b5e371603d0b40b2aaabbb8@linux-foundation.org> In-Reply-To: <51b75b2b4495d4ad7ed173d91a726379bdae2353.1529607879.git.vilhelm.gray@gmail.com> References: <51b75b2b4495d4ad7ed173d91a726379bdae2353.1529607879.git.vilhelm.gray@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jun 2018 17:07:08 -0400 William Breathitt Gray wrote: > This patch introduces the Generic Counter interface for supporting > counter devices. > +EXPORT_SYMBOL(count_direction_str); +EXPORT_SYMBOL(count_mode_str); +EXPORT_SYMBOL(counter_signal_enum_read); +EXPORT_SYMBOL(counter_signal_enum_write); +EXPORT_SYMBOL(counter_signal_enum_available_read); +EXPORT_SYMBOL(counter_count_enum_read); +EXPORT_SYMBOL(counter_count_enum_write); +EXPORT_SYMBOL(counter_count_enum_available_read); +EXPORT_SYMBOL(counter_device_enum_read); +EXPORT_SYMBOL(counter_device_enum_write); +EXPORT_SYMBOL(counter_device_enum_available_read); +EXPORT_SYMBOL(signal_read_value_set); +EXPORT_SYMBOL(count_read_value_set); +EXPORT_SYMBOL(count_write_value_get); +EXPORT_SYMBOL(counter_register); +EXPORT_SYMBOL(counter_unregister); +EXPORT_SYMBOL(devm_counter_register); +EXPORT_SYMBOL(devm_counter_unregister); The naming is a bit chaotic. Most of the symbols start with counter_, which is good. But a handful do not. Also, symbols called signal_* make my head spin - Linux already has a firmly ingrained notion of what a signal is, and this ain't it ;) Although the kernel tends to use sig_ for signals-as-an-IPC-thing. Also, many many drivers deal with signals-as-an-electrical-thing - is it appropriate for this particular driver to take that namespace?