Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp85903imm; Tue, 17 Jul 2018 21:29:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdqjoEjiMGoZHa72+9HyHOrEpFNJKbCfu4kI65VcichNV3rhOrUiLRTlYtuJqRj3EAOt2w8 X-Received: by 2002:a63:8e41:: with SMTP id k62-v6mr4133791pge.187.1531888168008; Tue, 17 Jul 2018 21:29:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531888167; cv=none; d=google.com; s=arc-20160816; b=OdfKQCHjCREKyqeC9YArFzgyE7xAtbYIEFP69SpdfB6jiV+m0b3Wd+MOSJFu0qOuZP dgTd3TsaB0HjZEle99UIPFKSgTlrgMiKBnC4KCOXYxij/phsCPUJaCtXMsCqI8pdS7tB AxVMqUFESVMcl2oBwi0ODHwHNoHmb08w7fZA7dzwt8JS1pwteY8LvBTAwR0xkykvqHEO pWnuNiT1u3MvSI1bftbqnMPph9Yy4z3oL+QBx4ihue8FYkCRkf1d5M1TnEnv29TsqypB pCa84R3Uc2IakLW1uVkgBaggbX8AFFryEt50yW0mT5ZT/t7uFiPYvbov+LyagsMz33Ff owog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=ZyaHLhfHN9O6vaWhYvIHBtSlHpTHCpMC3HoyL+YBfsE=; b=wxV56DCgNEHSN2S0jEDoHpb+qoXspjHVrqAzYgMdrvQB7Mg3zPaxd6FtlgirXIgpJN u19H5Q1XSjM5fjGtBEvE0oOz/dKTiQqYzLtVfAPcXUNDklxy9uE+V25ajD1bZXjgo8X4 zZfaUlci/AwoU89YqOzzeV9Sd15HqMxOryzheLqJSQE8byF30AUrEzRGEFRE7wHXC7qc q7g8wFtnGiJv3duSYsn7zfjOtF7bq/bXcq1tnd9dHAlcuGfUZbf7DTn3bmbPMt0OP+mj pOZDCUKqj7wkWLtj230mocbCp/MJhxLyijavv3bQo4zonLDkZHjEQXzXBABuE84WHeAh StxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e64-v6si2629155pfj.63.2018.07.17.21.29.12; Tue, 17 Jul 2018 21:29:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbeGRFEd (ORCPT + 99 others); Wed, 18 Jul 2018 01:04:33 -0400 Received: from namei.org ([65.99.196.166]:39506 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbeGRFEc (ORCPT ); Wed, 18 Jul 2018 01:04:32 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w6I4SR1c020679; Wed, 18 Jul 2018 04:28:27 GMT Date: Wed, 18 Jul 2018 14:28:27 +1000 (AEST) From: James Morris To: Arnd Bergmann cc: "Serge E. Hallyn" , Mimi Zohar , Kees Cook , David Howells , "Eric W. Biederman" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] security: export security_kernel_load_data function In-Reply-To: <20180717202355.2119407-1-arnd@arndb.de> Message-ID: References: <20180717202355.2119407-1-arnd@arndb.de> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jul 2018, Arnd Bergmann wrote: > The firmware_loader can be built as a loadable module, which now > fails when CONFIG_SECURITY is enabled, because a call to the > security_kernel_load_data() function got added, and this is > not exported to modules: > > ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined! > > Add an EXPORT_SYMBOL_GPL() to make it available here. > > Fixes: 6e852651f28e ("firmware: add call to LSM hook before firmware sysfs fallback") > Signed-off-by: Arnd Bergmann Thanks! Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris