Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp146071imm; Tue, 17 Jul 2018 22:59:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcKHc98rXX30jrtEoRoQcS3OwavOK5/dLP1NXFBNiMh7z51HE8euESg7936a3I89OUI64Kq X-Received: by 2002:a62:cac5:: with SMTP id y66-v6mr3779913pfk.187.1531893556644; Tue, 17 Jul 2018 22:59:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531893556; cv=none; d=google.com; s=arc-20160816; b=GOw+lltGk4bo2xNpzhqKETkqsLLzU9KjQ1HDb/2hQL5OR/oJLGDB1pMmJ9sKD/SuoY 2iB0k4swwzuUiusI80JanyhPVkmcSVIxb8BDxhjZuUCqtL8W1YWPrgHouPxkLRIvDi/C /eGanuuBLDaJi61+a8UuC/2YDklIGwHAOOOL1KaFWSWx5Y6b7EMNltkwcmkigZtW9PvT njjaK8BrFqN/3Rnv3cmPS0lNd6FtTjk/cRhodQa8l6dFxLb7+UIL4w7ZWes4tx9snW+I E+lMtBLMHiR4YjfVxrmLWkOAibb4Xp+mzVnTxEQI9Lgewrl0aaXf6Pn5gxJkDftLkEQP y8qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=TZzn958P/+n+ZtFqM5A3uH8D/X1QLQrXbxhn+TRcQLI=; b=l8I9PIzYgRnYSHHz1bEDWsBfY2RjYmWE8p+QpMPG39VWNbjZ/6TbrCNWjPq4Fcs6ag f/iqOdtiU+/IPeUM3scp3OpEMTrnTIvOLoJRxSIx+CWMpDZ31DlaWoxhEnwudvYF30cf qUzHnQleFWsOzsfiBnSNlObQFgHhFhnf08X4IVJm9X8C1Zl6WZBcz8lXbQp8A8zjf8CT OAIuMO9FuJf/VlS1AG+askN/AwRjkDWxvQog6nJ7ZyWSa7K/KbdmSwmJAYhdImzPowWl oF/hin8uclkd2H+AHmJ0CgVwr+Sv7eI1czIOoulzCjZ8puSEYhqhTy6g7GZ1V7TFNjNP /amQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FhrfOJTM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6-v6si2493009pgn.603.2018.07.17.22.59.01; Tue, 17 Jul 2018 22:59:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FhrfOJTM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726592AbeGRGeg (ORCPT + 99 others); Wed, 18 Jul 2018 02:34:36 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:38458 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbeGRGeg (ORCPT ); Wed, 18 Jul 2018 02:34:36 -0400 Received: by mail-pf0-f193.google.com with SMTP id v15-v6so1671460pff.5 for ; Tue, 17 Jul 2018 22:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TZzn958P/+n+ZtFqM5A3uH8D/X1QLQrXbxhn+TRcQLI=; b=FhrfOJTM6OAXYdUwJZJRagoJOJzxs0jA4A9OQkGF/eZ3/AFRXZ6KlGssXPM0Fqwol7 zrVxNJBMcIpXwmkXqsv/nCtrK12Xl8BcGCcPz/WOGcOnwudzNpdp/pDjSjoAsdYXwjYv eWaAW/FJcdB7nv2OHdxVq10dkvcQdBDtrIgEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TZzn958P/+n+ZtFqM5A3uH8D/X1QLQrXbxhn+TRcQLI=; b=o+aUItP5EVf87uuDg9EhNtjbnu6TeEf+5yHTDio9jC7/UN0YTnlc/+XEfF+nTGTiVr e1Bxu0F5EEl9pUzlB3lqDSyECjKrIvlEO/xt72bTyzKx5StbH3keevq7K7p/NWX/vupn Mwd2Yl8GVzD1Szk49nusiSd8VwIiBiASETfmUtOyfDZeJdED056dVg+FMttu7BxQo1EG G3soPpgFtEQgg+2fHkR4qgj48RYOL8lEmFZZBD5GD4ylcgekcKZM3iyzV9UOPpfYk9zT t6qlwkHCQjW8q4tbonvoHCIAeFNyDbIC1EKck/NFFf5v8weecJERT7Mw9oLvNpyUyHF6 QDPw== X-Gm-Message-State: AOUpUlFau+F/8vOqbDh+ClOQ8dvEaEdCKJSJFsQcew5wx9edZuhIlQ/3 nDC058qDZGJYSDli16T621AaTA== X-Received: by 2002:a63:4e22:: with SMTP id c34-v6mr379891pgb.6.1531893507358; Tue, 17 Jul 2018 22:58:27 -0700 (PDT) Received: from localhost ([122.171.235.75]) by smtp.gmail.com with ESMTPSA id f5-v6sm5654356pga.58.2018.07.17.22.58.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jul 2018 22:58:26 -0700 (PDT) Date: Wed, 18 Jul 2018 11:28:25 +0530 From: Viresh Kumar To: Wei Xu Cc: arm@kernel.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] arm64: dts: hisilicon: Add missing cooling device properties for CPUs Message-ID: <20180718055825.nrh7wk3cfuvib2ng@vireshk-i7> References: <0754957a2c3842cf4e36fa27231d327fd8d6d499.1527225682.git.viresh.kumar@linaro.org> <5B09A0B4.2080400@hisilicon.com> <5B09A5B4.4050904@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B09A5B4.4050904@hisilicon.com> User-Agent: NeoMutt/20180323-120-3dd1ac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26-05-18, 19:21, Wei Xu wrote: > Hi Viresh, > > On 2018/5/26 19:00, Wei Xu wrote: > > Hi Viresh, > > > > On 2018/5/25 6:40, Viresh Kumar wrote: > >> The cooling device properties, like "#cooling-cells" and > >> "dynamic-power-coefficient", should either be present for all the CPUs > >> of a cluster or none. If these are present only for a subset of CPUs of > >> a cluster then things will start falling apart as soon as the CPUs are > >> brought online in a different order. For example, this will happen > >> because the operating system looks for such properties in the CPU node > >> it is trying to bring up, so that it can register a cooling device. > >> > >> Add such missing properties. > >> > >> Do minor rearrangement as well to keep ordering consistent. > >> > >> Signed-off-by: Viresh Kumar > > > > Thanks! > > Applied to the hisilicon fix tree. > > Sorry for the noise! > It seems this patch is still under discussion. > I will drop it firstly. Wei, can you please apply it again now that all the discussions are over ? -- viresh