Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp270643imm; Wed, 18 Jul 2018 01:43:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeHFSPv1yD+5nctWhDQ+G5Zd369dH7gTcEBae7+fbylg2l27vsHj+GSqxxJULQeuFBHicrW X-Received: by 2002:a62:170c:: with SMTP id 12-v6mr4268537pfx.139.1531903386452; Wed, 18 Jul 2018 01:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531903386; cv=none; d=google.com; s=arc-20160816; b=fhOYyw4VveBnvnYX4q78f6+fUoguHlHMgQJEx0cPbpVrcN7qnv4mX7rOaPTAWXMFKq g7uM5GXqI+lpxIWnrdUyAaIx8KP2itWLwQALPpqX5wUlUONwWMUYvuJgl79xMbt9n8XI LXCxfoMzNsoRy3BLw07ZncX0oNs3hyNy6oT6CBPsMEtituFJ+qs4i3rfdVmg5k9MJ7IK +hecjchHvxSn/A4fIvqD/dY5Q6+QT+hgraddOIFae0GtwLFxQ2biBm6FxqsizWITwj4q /gwuk+XgoyEsP7inHAkW9WMqPd+nzu2lhU7pxGc7uc2K78WSfZ4rauBLJTybMxEqr7Ne FIgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=rXNjzO+h71AwjdimawDf6uvrcMpaeuKQ7SJt5XoJkvg=; b=qkSFzBLsHKHfNr1Nl9WM6eq8J6LUKnFv6vie/PLgp+00ZmIHdFFX7noPL9NrkxcMPk Qvd3E3kkmF8OKxbd3qjgFxv5DwreG5cf36lks/SIYayf7ORaGXkhZ+PCoPR5/qebZN76 kLN7QtlXJfKni8WJC+Xsyrxqzq9MEVRG9KRvFxjY8EnqTgwTxaUWT6pYS01CpT7t+UON ZTEOBu/1RC7e3gieLDJa6CogX5FXBcWORdbjAe4kC4yPlkbj0fX9nWCjLmvJzEQIGw0e Zk3xVq9g4F8V8aDtPQr6+/TvF7msD133spinkVFGKIP488eDAuihBrU/5vBfroXaHEY+ qHMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=VJ46FCsq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 13-v6si2887332ple.274.2018.07.18.01.42.51; Wed, 18 Jul 2018 01:43:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=VJ46FCsq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730600AbeGRJSS (ORCPT + 99 others); Wed, 18 Jul 2018 05:18:18 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:58116 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729677AbeGRJSR (ORCPT ); Wed, 18 Jul 2018 05:18:17 -0400 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id E406BB00769 for ; Wed, 18 Jul 2018 10:41:27 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=references:in-reply-to:x-mailer:message-id:date:date:subject :subject:to:from:from; s=dkim; t=1531903287; x=1532767288; bh=QL Fjdk0KB/PAgmrzHuXpIBFIft3DHWBiYN/NgB1WMC4=; b=VJ46FCsqbDyJSVJUzp QZ/uxqrh0UQf1FIvWeICBLYdYurv6ddborUNB+qpSarXdiPf14pJfoBuFS64z4xu iVTGxo1lfvlXyYE+qfdgeSe+EIts/ftKDa3nSgKHzq8rThqH5KEE5na+hnWWhzFj mIbGRZe4YgvHHHPeh/aIu3FD4= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=unavailable autolearn_force=no Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tDpuf8yXQkLq for ; Wed, 18 Jul 2018 10:41:27 +0200 (CEST) Received: from localhost.localdomain (62-11-51-166.dialup.tiscali.it [62.11.51.166]) by mail.micronovasrl.com (Postfix) with ESMTPSA id F0BCDB00789; Wed, 18 Jul 2018 10:41:25 +0200 (CEST) From: Giulio Benetti To: Andy Shevchenko Cc: Giulio Benetti , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Date: Wed, 18 Jul 2018 10:41:17 +0200 Message-Id: <20180718084118.79540-3-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180718084118.79540-1-giulio.benetti@micronovasrl.com> References: <20180716213302.GA2751@piout.net> <20180718084118.79540-1-giulio.benetti@micronovasrl.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On m41txx you can enable open-drain OUT pin to check if offset is ok. Enabling OUT pin with frequency_test_enable attribute, OUT pin will tick 512 times faster than 1s tick base. Enable or Disable FT bit on CONTROL register if freq_test is 1 or 0. Signed-off-by: Giulio Benetti --- drivers/rtc/rtc-ds1307.c | 96 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index b2ef9defc349..485e3d87e664 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1050,6 +1050,96 @@ static int m41txx_rtc_set_offset(struct device *dev, long offset) ctrl_reg); } +static ssize_t frequency_test_enable_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + struct ds1307 *ds1307 = dev_get_drvdata(dev); + bool freq_test_en = 0; + int ret; + + ret = kstrtobool(buf, &freq_test_en); + if (ret == -EINVAL) { + dev_err(dev, "Failed to store RTC Frequency Test attribute\n"); + return ret; + } + + regmap_update_bits(ds1307->regmap, M41TXX_REG_CONTROL, M41TXX_BIT_FT, + freq_test_en ? M41TXX_BIT_FT : 0); + + return count; +} + +static ssize_t frequency_test_enable_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct ds1307 *ds1307 = dev_get_drvdata(dev); + unsigned int ctrl_reg; + + regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg); + + if (ctrl_reg & M41TXX_BIT_FT) + return scnprintf(buf, PAGE_SIZE, "on\n"); + else + return scnprintf(buf, PAGE_SIZE, "off\n"); +} + +static DEVICE_ATTR_RW(frequency_test_enable); + +static struct attribute *rtc_freq_test_attrs[] = { + &dev_attr_frequency_test_enable.attr, + NULL, +}; + +static const struct attribute_group rtc_freq_test_attr_group = { + .attrs = rtc_freq_test_attrs, +}; + +static void rtc_calib_remove_sysfs_group(void *_dev) +{ + struct device *dev = _dev; + + sysfs_remove_group(&dev->kobj, &rtc_freq_test_attr_group); +} + +static int ds1307_add_frequency_test(struct ds1307 *ds1307) +{ + int err = 0; + + switch (ds1307->type) { + case m41t0: + case m41t00: + case m41t11: + /* Export sysfs entries */ + err = sysfs_create_group(&(ds1307->dev)->kobj, + &rtc_freq_test_attr_group); + if (err) { + dev_err(ds1307->dev, + "Failed to create sysfs group: %d\n", + err); + return err; + } + + err = devm_add_action_or_reset(ds1307->dev, + rtc_calib_remove_sysfs_group, + ds1307->dev); + if (err) { + dev_err(ds1307->dev, + "Failed to add sysfs cleanup action: %d\n", + err); + sysfs_remove_group(&(ds1307->dev)->kobj, + &rtc_freq_test_attr_group); + return err; + } + break; + default: + break; + } + + return err; +} + /*----------------------------------------------------------------------*/ static int ds1307_nvram_read(void *priv, unsigned int offset, void *val, @@ -1792,6 +1882,12 @@ static int ds1307_probe(struct i2c_client *client, if (err) return err; + err = ds1307_add_frequency_test(ds1307); + if (err) { + rtc_device_unregister(ds1307->rtc); + return err; + } + if (chip->nvram_size) { struct nvmem_config nvmem_cfg = { .name = "ds1307_nvram", -- 2.17.1