Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp459989imm; Wed, 18 Jul 2018 05:19:56 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcS2qOgsVFrlx1+6T8IoppxdcAkLmI+D6jG4N6znRaDqlZ0VGJuuya4QDw1cLDDINWf/PZa X-Received: by 2002:a62:45d2:: with SMTP id n79-v6mr4935110pfi.137.1531916396385; Wed, 18 Jul 2018 05:19:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531916396; cv=none; d=google.com; s=arc-20160816; b=ZnsNEu/Upr8CkvPWZguO6xd/UO/lNVqOxG+Dg4HUMZsDfDua3ReJf6M1W+PyQBCWq0 q7YjQjORf2fNjAJCv088oMLlvT0MslqKQSx9XNBFBaJLoPqx1EqC548sxqrm43tFz8MW Y9PaqacF4h43bBlgs6v4ACb/S+lcyBPxkTdMSULUSJndHgMtGuDG8FHXWJ29beOPi11j hiJiN2iJPfqecBTevLjoTxCPj9M7IeHycCIW2Fjh81JKJFkSSMiDT7OfC3h/dnyFkpRP dlYmDGyz/Qr34zJ+WVWuGuf3wrcVlcOiOGsKIYGJi+n653uRs/0IgB7hIX3244pgQEy8 pmeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zv/Bukss8miI4m7ZxRFp4HGODf/AqREhaos9EiKOAO0=; b=wqEzWXhqFrZ1l7JpM0CIo2gCdno6xdoeVjqX2xKD51pa8ql1gghPjfFWst6lc4sKuw 2QhQhIrlQDH5Ngml5GQ1F8zZoqPDEmnm06jmus3abW2Wf7OHP8S+qPlFtTosApH9XQKl 9xncFizlk4sw37hFjw1+9NX7ioDJIVOO7crDABQhclLtMh/XRCMjGDxLcfyLV9CpQPd0 LJiH73OwG7p6OBFQ500u6tihDBaJ+zCurkp4qUVDf0rsaOdXIOKuM1iJIlzw2BEM18S7 ygA/GSVR7tpDvPDPwsq9XcNPcHbj6/T2n9cgOnwxDorTcB8iiFYPBPzzzoxkys7r06We vT4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2-v6si3199888pgh.661.2018.07.18.05.19.40; Wed, 18 Jul 2018 05:19:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729594AbeGRM4P (ORCPT + 99 others); Wed, 18 Jul 2018 08:56:15 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:56008 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726699AbeGRM4P (ORCPT ); Wed, 18 Jul 2018 08:56:15 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fflPe-0001dX-6v; Wed, 18 Jul 2018 12:18:34 +0000 Date: Wed, 18 Jul 2018 13:18:34 +0100 From: Al Viro To: Miklos Szeredi Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 (v4.18 regression fix)] vfs: don't evict uninitialized inode Message-ID: <20180718121833.GR30522@ZenIV.linux.org.uk> References: <20180706204521.29654-1-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 01:40:08PM +0200, Miklos Szeredi wrote: > Ping? > > This (or some variant) needs to go into 4.18. Yes - icache series is on the top of my list, now that -open stuff is (hopefully) sorted out (in for-next, anyway). I'm putting together a queue with that stuff at the moment. BTW, why have you left generic_readlink() sitting around? AFAICS, it could've been folded into the only remaining caller just as you've made it static in late 2016... I'll fold it in; just curious what was the reason for not doing that back then...