Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp514227imm; Wed, 18 Jul 2018 06:14:24 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcsMvI8AutDprvi3yzDpEs6UVjjkf1AmG9294WfN4iyGItXU/0fTrlrDUwkkpPqG3metBV7 X-Received: by 2002:a63:b00f:: with SMTP id h15-v6mr5836301pgf.442.1531919664372; Wed, 18 Jul 2018 06:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531919664; cv=none; d=google.com; s=arc-20160816; b=i2QVsihuVD3ULRwPd0EVB0CJJY02E6T/HQaQcVYuYOYg8CE5zcSYivd52Ku+gxNd9/ SrZyiwV+4SUMorSM/48hlBG+ROHoBZSvxoU1WV3Y+qegNFS8QxM75G0fiipbRO2Log0o B3xI+oexN1BZplmOXfi7SFL9Rm73jDM8xQ9oYNfv8Ze4VwTzf9He3bacRdHe5aMXU4FC G1uqdt6BPFoRKceItb9mDO6rWnrGAeMkoYnMvpu+Gur4UyhHPhx+mPKCLXvWkHsauaGT PANRF7PRaTLQ4uD4MwTj5ZDlYE4fMln4OAj0n84a1K/7VztIrR6yR7czxc5aKmB6OEEe tzhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=374ljsi9NVFEvDQfZ4cCjoUnIKOoKKsp1Z+zVA6bOPY=; b=ydTjfhMbL1iXc0J0zW9EiTMu/2h3Z0w8GgA2vwWbqCzaQvl+/+1ENBz3wR1Bn/U7no o5cnnTgt0cesMamHMElWBEjUfqfA7c8Sf75ibi8nGfLgpOpr1AEFS9nh6gpeXX9ptS62 irrHGvGZlnZHkQFb9BWLDwFytUghppP+zvzSoKxA8ZViqAGis97boKFSgyWISYBZ7Svb QfKGP2TQu03aD6CTWlV+77EHHZYkQSicSRnw2zU1ec5csQiokcM6AmsEs4ZG5eIJcD+e j9WGjojBlR1kDQ0XbP05JqwzxTwy0zppSYTBMc+dElcs8wHLrzNGwMjONMhkMo7w2RmW fNPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z13-v6si3443838pgc.409.2018.07.18.06.14.09; Wed, 18 Jul 2018 06:14:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730859AbeGRNv0 (ORCPT + 99 others); Wed, 18 Jul 2018 09:51:26 -0400 Received: from inva020.nxp.com ([92.121.34.13]:47708 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbeGRNv0 (ORCPT ); Wed, 18 Jul 2018 09:51:26 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 5C7E91A002D; Wed, 18 Jul 2018 15:13:32 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 50E111A0012; Wed, 18 Jul 2018 15:13:32 +0200 (CEST) Received: from fsr-ub1464-019.ea.freescale.net (fsr-ub1464-019.ea.freescale.net [10.171.81.207]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 76BA5205E1; Wed, 18 Jul 2018 15:13:31 +0200 (CEST) From: Camelia Groza To: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Camelia Groza Subject: [PATCH] net: phy: use generic clause 45 autonegotiation done Date: Wed, 18 Jul 2018 16:12:15 +0300 Message-Id: <1531919535-20269-1-git-send-email-camelia.groza@nxp.com> X-Mailer: git-send-email 1.9.1 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only Clause 22 PHYs can use genphy_aneg_done(). Use genphy_c45_aneg_done() for PHYs that implement Clause 45 without the Clause 22 register set. This change follows the model of phy_restart_aneg() which differentiates between the two implementations in a similar way. Fixes: 41408ad519f7 ("net: phy: avoid genphy_aneg_done() for PHYs without clause 22 support") Signed-off-by: Camelia Groza --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 537297d..4fcc703 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -151,7 +151,7 @@ int phy_aneg_done(struct phy_device *phydev) * implement Clause 22 registers */ if (phydev->is_c45 && !(phydev->c45_ids.devices_in_package & BIT(0))) - return -EINVAL; + return genphy_c45_aneg_done(phydev); return genphy_aneg_done(phydev); } -- 1.9.1