Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp525070imm; Wed, 18 Jul 2018 06:24:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcCtooAjqBMBjqaHOSWmUH+9WBegjGYd1srHlxWz7GNFHyyQfv4+iltWrMzkYe82YpQW3gK X-Received: by 2002:a62:3184:: with SMTP id x126-v6mr5245032pfx.49.1531920291370; Wed, 18 Jul 2018 06:24:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531920291; cv=none; d=google.com; s=arc-20160816; b=C+wPB8y9jfPhyWs1g4BG3SvVbTSNk6EaUXs6X58ZUgEYVZ6BzWMarY3DSUe+hKNANb U3nKGIVBvLzIIuxI/8Sw7hnmJRYj+4t4SErMk3qt1L+2rY7+iPboxYVkHgzCLvHkYS2i ZbtgmD9E/2pRX2r4V8yze1nxtQlxZWsuJgf4R7pn0Fwdpm/Fl89Oavlx8o8qAgeZ1yj3 GTNh/X/2zrP5JMdea1C26keWwo7hC8wYVehQBp1ipLiGxEVAI+2pfoxfTuPf8lf2c3wp fs5zMt/qE4CdyMvcVfNTOK/1r6TS0H7dd7YDP0y0OhUKki8Z7c/XPtHCD0kYhvkqTnFL oAxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=54ecmanpXF2h+VGNu0dPqA7o19zoWsA3un8FzOqNEs0=; b=ORGL8bLkaDMzGwwesEUD+SzmLIL2mmFHjtB17ReUv5OXIsDdhd+oZ0PepyUwmT2hTK lUyBGTwcTszRUOUo/+QhO0uQDi1fB1nxa/AXJRBwxQ/GfYrNaymcdBXrVrIPBzoW5B5l UlxnQlmgRxBmsE2qcl8l4WIwCF4hAyXl3y/XbcL6/DgRqKgJdIKEHqP/ayaJ2Zmo7slC bE9Ohj7nnY16JiI98uEf3Xri/ku0ReJHJQGxMIZQPeFvw/3OHdN8CFmrxeXbfeNhT3ho yKZtukbhhIOLgt1QNN+ovrK0yWYJ5TSu9or4AvWbUHE7LM5FqyO+72qc2DfZb/4J2AGe ANIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q67-v6si3245205pga.63.2018.07.18.06.24.36; Wed, 18 Jul 2018 06:24:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731468AbeGROBR (ORCPT + 99 others); Wed, 18 Jul 2018 10:01:17 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44680 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731215AbeGROA7 (ORCPT ); Wed, 18 Jul 2018 10:00:59 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6IDJ2bg002584 for ; Wed, 18 Jul 2018 09:23:05 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ka3x163at-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 18 Jul 2018 09:23:04 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Jul 2018 14:23:02 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 18 Jul 2018 14:23:00 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6IDMwUH37814398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Jul 2018 13:22:58 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 64E09A4040; Wed, 18 Jul 2018 16:23:16 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B00FA4069; Wed, 18 Jul 2018 16:23:16 +0100 (BST) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 18 Jul 2018 16:23:16 +0100 (BST) From: Ursula Braun To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, raspl@linux.ibm.com, linux-kernel@vger.kernel.org Subject: [PATCH net 2/3] net/smc: add error handling for get_user() Date: Wed, 18 Jul 2018 15:22:50 +0200 X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180718132251.7222-1-ubraun@linux.ibm.com> References: <20180718132251.7222-1-ubraun@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18071813-0016-0000-0000-000001E8509E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071813-0017-0000-0000-0000323D0A05 Message-Id: <20180718132251.7222-3-ubraun@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-18_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=974 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807180150 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ursula Braun For security reasons the return code of get_user() should always be checked. Fixes: 01d2f7e2cdd31 ("net/smc: sockopts TCP_NODELAY and TCP_CORK") Reported-by: Heiko Carstens Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index c12a7fc18f56..6e5479067db0 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -1456,7 +1456,8 @@ static int smc_setsockopt(struct socket *sock, int level, int optname, if (optlen < sizeof(int)) return -EINVAL; - get_user(val, (int __user *)optval); + if (get_user(val, (int __user *)optval)) + return -EFAULT; lock_sock(sk); switch (optname) { -- 2.16.4