Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp573429imm; Wed, 18 Jul 2018 07:10:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf652tv4WQ9MISAd1sDvzzRRDLDQomGeSzAPD2S/dGNpVDFYDkZkPZcQ2OilVjglQJ52AaI X-Received: by 2002:a62:225d:: with SMTP id i90-v6mr5293754pfi.246.1531923032571; Wed, 18 Jul 2018 07:10:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531923032; cv=none; d=google.com; s=arc-20160816; b=LDHRsORoUN8Qh6hcIQio0+dPqa/SsxTFTmfJZLQvQN5cH2JYLs2IgR1rX311CVhiJy 55C4jVJxeo9POpmjmu/XVQlH8kK6dgU5IYHrtWqKqqCVslRXFpoQ2GiY0sJJ6hyl7NH8 GgUY/3TSY0vhF2LHWfJnuBGemsiFGbXU58GJTmLp/PYF9cAI48ETmWhHpIcL8q4MVRMC c1izdZTRno29MeQCHCeHul1wx/l+j8fJq4N67iOVgWawC9EqCiu2+C0UgcYedp0WRAbt 8Q3k/ls8VImf3WVR4ImhtIVqhB3tb2qbL9blYLFMRg7C1sX0Gqa+g3pTJBTmkQ/zmkb7 wWNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=hM+1taqqbul4xeeDpWzOOJMS9Splow7U6gUkOKjga3g=; b=ciK+tvXs8iKce6jlILFZjjQVXlFB3nx/tDrQMrjq+p4eXq6DT7ZfczhBONcxkWVcDc TLYZBHi3mDDVLvsFhHzKc+jcOinRrPf4ejaQgzBgDgjgV1vz/zkHq0MYSJZKdjpSLyBk vQ/lZXDqqpEFEYlzGZ3UVN02ovLR3ox+ei0ba4vofDpywuEWIYlKQ95sqleXotu8dDTN TmM0Zmdlb+icvVTlwkIIM7Pn+5FlxtWPrLJN0fg8g8wRGb1l2Q2Wt0a6Y4zoYV8Uro41 aEMRz21g85WLTn1PV7xtTuDU84DJ5GFUry2rKVlFjrfuHGu2AAsQkLaK62jsHXIHFyjH PRkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1-v6si3041812pld.424.2018.07.18.07.10.17; Wed, 18 Jul 2018 07:10:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730543AbeGROrr (ORCPT + 99 others); Wed, 18 Jul 2018 10:47:47 -0400 Received: from mail.bootlin.com ([62.4.15.54]:55005 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729667AbeGROrr (ORCPT ); Wed, 18 Jul 2018 10:47:47 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id EE17C20732; Wed, 18 Jul 2018 16:09:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bootlin.com (AAubervilliers-681-1-27-161.w90-88.abo.wanadoo.fr [90.88.147.161]) by mail.bootlin.com (Postfix) with ESMTPSA id 91040203EC; Wed, 18 Jul 2018 16:09:39 +0200 (CEST) Date: Wed, 18 Jul 2018 16:09:39 +0200 From: Maxime Chevallier To: "Gustavo A. R. Silva" Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator Message-ID: <20180718160939.5650559b@bootlin.com> In-Reply-To: <20180718130846.GA5380@embeddedor.com> References: <20180718130846.GA5380@embeddedor.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, On Wed, 18 Jul 2018 08:08:46 -0500 "Gustavo A. R. Silva" wrote: >The use of the | operator always leads to true, which looks rather >suspect in this case. > >Fix this by using & instead. > Acked-by: Maxime Chevallier Good catch, thanks. Maxime