Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp644827imm; Wed, 18 Jul 2018 08:17:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcOqwZsHP9VNAPmJCMyWX1FmXhPpQ+abqAuElolRMlBLmJEdrrCVnOF8BQMqYU2p7Kkcatq X-Received: by 2002:a62:f587:: with SMTP id b7-v6mr5634669pfm.158.1531927078109; Wed, 18 Jul 2018 08:17:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531927078; cv=none; d=google.com; s=arc-20160816; b=WMYhi43jkJhboTOYcMe2IyhHBoIEm0EHNYfM1m+kZrGuSeim9GieinvAiBg1SdN7mh 99412MUjFotu48W88NGw6Y7tHHSVrM7o0/PJPpVcn4xlfITuUOhw3IqBgFNa9tRvLsf/ JpoTk9r5B31fi/0sNI6WtqDDvuKOSQdVH8BMHmH5kQjs3ue0+XbQhbrcT4+LfmN6vD22 yJDLssDUjX4S4lYykYywri9EM+ZUUKAu0Y/gAbtgYWjvJCws2gKeTBa93hk02+PbfYHM AxbcD6r2W36EmDMr0NBzR+NjJ9RvqBVLUhrplUhMW+y0i5RHoJS+OidXmlOFzfNWT7gM gyWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qlYBls4QPCyb6ui+qsuEPi2v7Wk3AlrjAATQOhJwVz4=; b=Qnh/20kk7lUNV3ewS0GTmHDPCuOdaTiFViF02BwZbtfNbwmH6tM3784W7h2lY+BZhT xE3qLkhhS96ghBT9aq7TohyMuQeYrKeWcu8iQW/QRnDlwgpYq76xbZfEkeVxR42233Sp v8IwfvuvG0NK1WrkD701Y9xeHGcoG9XkeGEjpqJMLGSHNUUyShCYaOcyJmFx8YA6qn86 s+k7dXOHbcpgg9bnQmy1X5iL9ubHzm9fXS1e6NFyLP59asGOxJy1yWMmC4TcZlPr+NC2 PQBtVNNjPL6ZEi66G6Mp8eX/d9/pKxPgghlwrrODcDPBMea3X//MqXZTPUXbf/gPr6V4 cAiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3-v6si3370176pgp.220.2018.07.18.08.17.43; Wed, 18 Jul 2018 08:17:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731319AbeGRPyP (ORCPT + 99 others); Wed, 18 Jul 2018 11:54:15 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38842 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731251AbeGRPyO (ORCPT ); Wed, 18 Jul 2018 11:54:14 -0400 Received: by mail-wr1-f66.google.com with SMTP id v14-v6so5073846wro.5 for ; Wed, 18 Jul 2018 08:15:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qlYBls4QPCyb6ui+qsuEPi2v7Wk3AlrjAATQOhJwVz4=; b=Yfssq3BAONQkLoST+hNhGTwq2lmY14eFHB7OvV3FZVa6fOPY6G0sce3UUX2hY50fxE gSd9t+a0T9rl77cQewV6bciIiF3Afbt7WQOBeOvtrSGIjHZujjvQIi06KiOIaCDzbcq+ YEAvsUKzX+p+HntgAeaXy1uTqfXcCUBinz2NTonDpPLyVeNYSgr1RAZIGGPt7yMqz7TE xbvLWyqHo0K3TdvMzaNh+6KUebkVnAxEvp5bgMtB2+qykw4c/xOORrlItfr6PZsgzYOD 0qhyJnMU9kvd+3vzKxhRbTfgD7nBTUGmhp9uoPiTkpGQv5e8NPqIdzxRFtjY79OhwQw7 ILmg== X-Gm-Message-State: AOUpUlE7fytF2xNTlNKh9p1W1IC1r2TATkY0jovyjnegoi8EP2b41by7 zosxhsNz6VsK1JJqMiq+JiM= X-Received: by 2002:adf:ff49:: with SMTP id u9-v6mr5156517wrs.15.1531926952136; Wed, 18 Jul 2018 08:15:52 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id r1-v6sm4611499wrs.39.2018.07.18.08.15.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 08:15:51 -0700 (PDT) Received: by techadventures.net (Postfix, from userid 1000) id EE66B1240EE; Wed, 18 Jul 2018 17:15:50 +0200 (CEST) Date: Wed, 18 Jul 2018 17:15:50 +0200 From: Oscar Salvador To: Pavel Tatashin Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, iamjoonsoo.kim@lge.com, aaron.lu@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Oscar Salvador Subject: Re: [PATCH 1/3] mm/page_alloc: Move ifdefery out of free_area_init_core Message-ID: <20180718151550.GA2985@techadventures.net> References: <20180718124722.9872-1-osalvador@techadventures.net> <20180718124722.9872-2-osalvador@techadventures.net> <20180718141150.imiyuust5txfmfvw@xakep.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718141150.imiyuust5txfmfvw@xakep.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 10:11:50AM -0400, Pavel Tatashin wrote: > On 18-07-18 14:47:20, osalvador@techadventures.net wrote: > > From: Oscar Salvador > > > > Moving the #ifdefs out of the function makes it easier to follow. > > > > Signed-off-by: Oscar Salvador > > Hi Oscar, > > Reviewed-by: Pavel Tatashin > > Please include the following patch in your series, to get rid of the last > ifdef in this function. > > From f841184e141b21e79c4d017d3b7678c697016d2a Mon Sep 17 00:00:00 2001 > From: Pavel Tatashin > Date: Wed, 18 Jul 2018 09:56:52 -0400 > Subject: [PATCH] mm: access zone->node via zone_to_nid() and zone_set_nid() > > zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to > have inline functions to access this field in order to avoid ifdef's in > c files. Hi Pavel I will! Thanks for the patch ;-) -- Oscar Salvador SUSE L3