Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp661108imm; Wed, 18 Jul 2018 08:34:04 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcGzOMNFP1IU4lvYCHkT/+Wk3V5lTWRLTGHtXyoznpVgW3KA9XCxPy3FfytYs/dWRIcq5Wg X-Received: by 2002:a65:5b8e:: with SMTP id i14-v6mr6290646pgr.242.1531928044339; Wed, 18 Jul 2018 08:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531928044; cv=none; d=google.com; s=arc-20160816; b=KyQM89NHUUV8pODf8kwvLco0aY6cxJoLB3gOAy6Rg592u6wZXz+0Und1rDEZdvIvSJ 5tMEFYZ4IHRe+1V6gSMTT9bxCwELr48UsnTXKvvHNSyngZyGE9mYIwtPtWUjH5r22LxH b/oRDCHU3mG7EZ98BswIgYUDIsl7wZGuxfsk1atbDR0CCi0EIZfvkHHLaAd8AWSjuMvZ 1Kpz3uEXMJyGnxS2kAbwcnsBUTTp80WJpxBIA2jfz4ZawEU++ffDdkvWP8YcdLFLR8Km 8az8q3QdsCw5XF/CkH229YvOY3/tP6pyHR74kPPZMureZpcGKvkwclax/k/Gar+OqAi/ yZVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:arc-authentication-results; bh=q1HG47jAAqYAVQcqPKUIrLdNSZxG8qaumCQeRhgTrYc=; b=rj6s94Ri3X4pnc94oSs3KuQmxi7rY0/lRSUtjOrYCmP8vsDlEGs7dlE4/FzPEGm8Ta jaeJdek4GzdOa+BebELEzTlg2q3nDnULrcalH1Bteh9/t4GRx706OcRFic5jjz0SGVsq baviLdZLe3x7rdotL5ZEdwVGA0mTw9cJekBsJmQdo91IQPMf1g7d+3jCQCJ/LbDZJ9pO qv5KOYhVAOyXOAYuMLzxOEziz5T9O86vpKeY6M+ULltjYaP2f+ZZJR/89Ykb8KlC6K48 +GgSqnXUeRVYlgmFWphgizKiCnh9s6GF2kncJ4zoP+NrFW5kgXmfhlJYRgw9h96bz7nJ KzFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11-v6si3546906plr.261.2018.07.18.08.33.49; Wed, 18 Jul 2018 08:34:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731313AbeGRQL2 (ORCPT + 99 others); Wed, 18 Jul 2018 12:11:28 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:47112 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730982AbeGRQL2 (ORCPT ); Wed, 18 Jul 2018 12:11:28 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 6454098C08E92; Wed, 18 Jul 2018 23:32:54 +0800 (CST) Received: from [127.0.0.1] (10.202.226.42) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.382.0; Wed, 18 Jul 2018 23:32:50 +0800 Subject: Re: [PATCH 3/6] arm64: dts: hisilicon: Add missing cooling device properties for CPUs To: Viresh Kumar , , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon References: <0754957a2c3842cf4e36fa27231d327fd8d6d499.1527225682.git.viresh.kumar@linaro.org> CC: Vincent Guittot , , Daniel Lezcano , , , , From: Wei Xu Message-ID: <5B4F5D9B.8070008@hisilicon.com> Date: Wed, 18 Jul 2018 16:32:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <0754957a2c3842cf4e36fa27231d327fd8d6d499.1527225682.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.42] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, On 2018/5/25 6:40, Viresh Kumar wrote: > The cooling device properties, like "#cooling-cells" and > "dynamic-power-coefficient", should either be present for all the CPUs > of a cluster or none. If these are present only for a subset of CPUs of > a cluster then things will start falling apart as soon as the CPUs are > brought online in a different order. For example, this will happen > because the operating system looks for such properties in the CPU node > it is trying to bring up, so that it can register a cooling device. > > Add such missing properties. > > Do minor rearrangement as well to keep ordering consistent. > > Signed-off-by: Viresh Kumar Thanks! Applied to the hisilicon dt tree. Best Regards, Wei