Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp803721imm; Wed, 18 Jul 2018 10:57:03 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf++dlZHeKsVbVo88Ldk7hsduHb5EDR2XXAPY7Y6tCVbUfYkl/BzuGtpe3Kke++TXkUMucR X-Received: by 2002:a63:951e:: with SMTP id p30-v6mr6725909pgd.318.1531936623402; Wed, 18 Jul 2018 10:57:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531936623; cv=none; d=google.com; s=arc-20160816; b=DGj8yPUaj0/vPRcMCqE3+eM0kGUPUlVDpXg2fIAySDT6TQ4QlLwjiP+rjf3GSzHLGs lFxkJq4/Fimg/U5VIVBJ1H6dLo5DstWCobd82HLPyJY0+X0V97ZA5Jk5vtR+cdnABM4d oTsjo9DPqMDzgTamP6FHOrkS6LR5/DYCqt7b0T0GC1RzEqE8GEN/YR6hcOoUDe52Mnqv Nv9X+74cOz+MD4bmxBV2S6QUczAmOO02L2YEt/rvPcrPvcAwDEolkRKlvvR5OqC7oroG aHGqfAAukAaXl0bZ6ScuBSO4W2lLPDxUrZ8n00o0acpbBNJz6OHf1l51LurobN2x5IJ/ vGjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=M6kB8fxJ+Kx8zmlisW1ZPfW1i7REiP9v+wpEFvpVOfE=; b=s84Xdy6UoBhueXR+22eBH40uzFJ9igBA9ZHEJyR0VA+M+lA7Mo98fNqyqOQyVbxz0S ckbZvMhhwHT+6z2JWU5sMi83HBWwXMlVZ3bgAxmTM53jTL72B0a2lIXxtbLFUY8ohYzz IxoH/3eF0EY1klhafylOnegPh94OC2d2FBVFeclUZDY4A1ehzsJXEN2eLJdIpDw6IB4Y Gv0d3jCsEtARE6Vk4knBElJtYDUKBqBK5z2kYpxzczF6A4j2F4T21SwMZUN4Nk7U0xhf YFkTzIO86UXEo9Ge0oAICh1uKYU4JBF1WHTu+rZhUgNW+M4OLkDWBc8jGQdcH1Wwj4zB MLxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1-v6si3612146pld.515.2018.07.18.10.56.48; Wed, 18 Jul 2018 10:57:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731583AbeGRSfI (ORCPT + 99 others); Wed, 18 Jul 2018 14:35:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40562 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731236AbeGRSfH (ORCPT ); Wed, 18 Jul 2018 14:35:07 -0400 Received: from localhost (unknown [24.18.143.0]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 58147140246B4; Wed, 18 Jul 2018 10:56:07 -0700 (PDT) Date: Thu, 19 Jul 2018 02:56:04 +0900 (KST) Message-Id: <20180719.025604.450540611611561398.davem@davemloft.net> To: gustavo@embeddedor.com Cc: maxime.chevallier@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator From: David Miller In-Reply-To: <20180718130846.GA5380@embeddedor.com> References: <20180718130846.GA5380@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jul 2018 10:56:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Wed, 18 Jul 2018 08:08:46 -0500 > The use of the | operator always leads to true, which looks rather > suspect in this case. > > Fix this by using & instead. > > Addresses-Coverity-ID: 1471903 ("Wrong operator used") > Fixes: dba1d918da02 ("net: mvpp2: debugfs: add entries for classifier flows") > Signed-off-by: Gustavo A. R. Silva Applied, thanks.