Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180718175545.GA11749@flask>
References: <1531214840-24686-1-git-send-email-karahmed@amazon.de>
 <1531214840-24686-2-git-send-email-karahmed@amazon.de> <20180718175545.GA11749@flask>
From:   Jim Mattson <jmattson@google.com>
Date:   Wed, 18 Jul 2018 11:03:55 -0700
Message-ID: <CALMp9eSv0ax6owRV78Xo9gw1T=_29_wg4LqbhNJP6+Hd_EU1Og@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] kvm: nVMX: Introduce KVM_CAP_NESTED_STATE
To:     =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc:     KarimAllah Ahmed <karahmed@amazon.de>,
        LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        "the arch/x86 maintainers" <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 18, 2018 at 10:55 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redh=
at.com> wrote:

>> +     vmx->nested.nested_run_pending =3D 1;
>
> This is not necessary.  We're only copying state and do not add anything
> that would be lost on a nested VM exit without prior VM entry.

If nested_run_pending is blindly set on restore, then prepare_vmcs02
will do the wrong thing. For example, if there was an injected event
in the vmcs12, it will get injected again, even if the vCPU has been
in L2 for some time.

The value of nested_run_pending should always come from the saved VMX
state (a few lines above).