Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leo Li <leoyang.li@nxp.com>
To:     Roy Pledge <roy.pledge@nxp.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: RE: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to
 drivers/soc/fsl
Thread-Topic: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to
 drivers/soc/fsl
Thread-Index: AQHUFJguec14uSA7bUePWN2SnCGRW6SVTIIA
Date:   Wed, 18 Jul 2018 18:10:24 +0000
Message-ID: <AM0PR04MB4867D7E843D3EAFB73EF939D8F530@AM0PR04MB4867.eurprd04.prod.outlook.com>
References: <20180705194113.16256-1-roy.pledge@nxp.com>
 <20180705194113.16256-2-roy.pledge@nxp.com>
 <119c6fc6-a32d-45a5-96ea-f6e9959b1e74@nxp.com>
 <VI1PR04MB44942CF2B2E5BA1C6CE8D17786440@VI1PR04MB4494.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB44942CF2B2E5BA1C6CE8D17786440@VI1PR04MB4494.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a9ae1b34-0e81-4f69-2a40-08d5ecd9bc24
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2018 18:10:24.9957
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5313
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Roy Pledge
> Sent: Monday, July 9, 2018 10:24 AM
> To: Laurentiu Tudor <laurentiu.tudor@nxp.com>;
> devel@driverdev.osuosl.org; linux-arm-kernel@lists.infradead.org;
> gregkh@linuxfoundation.org; Leo Li <leoyang.li@nxp.com>
> Cc: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>; Horia Geanta
> <horia.geanta@nxp.com>; linux-kernel@vger.kernel.org; arnd@arndb.de;
> catalin.marinas@arm.com; robin.murphy@arm.com
> Subject: Re: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to
> drivers/soc/fsl
>=20
> On 7/9/2018 6:37 AM, Laurentiu Tudor wrote:
> > Hi Roy,
> >
> > Couple of comments inline.
> >
> > On 05.07.2018 22:41, Roy Pledge wrote:
> >> Move the NXP DPIO (Datapath I/O Driver) out of the drivers/staging
> >> directory and into the drivers/soc/fsl directory.
> >>
> >> The DPIO driver enables access to Queue and Buffer Manager (QBMAN)
> >> hardware on NXP DPAA2 devices. This is a prerequisite to moving the
> >> DPAA2 Ethernet driver out of staging.
> >>
> >> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
> >> ---
> >>   MAINTAINERS                                                    |  2 =
+-
> >>   drivers/crypto/caam/sg_sw_qm2.h                                |  2 =
+-
> >>   drivers/crypto/caam/sg_sw_sec4.h                               |  2 =
+-
> >>   drivers/soc/fsl/Kconfig                                        | 10 =
++++++++++
> >>   drivers/soc/fsl/Makefile                                       |  1 =
+
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/Makefile          |  =
0
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-cmd.h        |  =
0
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.c     |  =
2 +-
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.txt   |  =
0
> > Maybe this should be converted to .rst and go in the already existing
> > Documentation/networking/dpaa2/?
>=20
> I can look into converting this to RST but I'm not sure it belongs in the
> networking documentation folder since it will be used by other non
> networking drivers in the near future - compress/decompress for example.
> >
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-service.c    |  =
2 +-
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.c            |  =
0
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.h            |  =
0
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.c    |  =
2 +-
> >>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.h    |  =
2 +-
> >>   drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h                 |  4 =
++--
> >>   drivers/staging/fsl-mc/bus/Kconfig                             |  9 =
---------
> >>   drivers/staging/fsl-mc/bus/Makefile                            |  2 =
--
> >>   {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-fd.h |  =
0
> >>   .../staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-global.h  |  =
0
> >>   {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-io.h |  =
0
> >>   20 files changed, 20 insertions(+), 20 deletions(-)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/Makefile (100%=
)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-cmd.h (10=
0%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.c =
(99%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.tx=
t
> (100%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-service.c=
 (99%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.c (100%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.h (100%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.c
> (99%)
> >>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.h
> (99%)
> >>   rename {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-f=
d.h
> (100%)
> >>   rename {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-
> global.h (100%)
> >>   rename {drivers/staging/fsl-mc/include =3D>
> >> include/soc/fsl}/dpaa2-io.h (100%)
> > I received feedback in the past on mc-bus that a driver should limit
> > to only one public header and one private one. Would it make sense to
> > do the same for dpio too?
> Looking at this the dpaa-2global.h file should probably be integrated int=
o the
> dpaa2-io.h file.
> The dpaaa2-fd.h can be used by devices that don't need to used DPIO - the
> definition of a frame descriptor isn't DPIO specific so I would argue it =
should
> be kept in a seperate file.

Hi Roy,

Will there be a re-spin of the patch soon so that we can probably catch the=
 next merge window?

Regards,
Leo