Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp903055imm; Wed, 18 Jul 2018 12:46:33 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfGt5rZ8o/AvvSE0G7a9AT8xuC6g0KLONiOZidp6Agr3cC7br4DzPM+I1TQV0mLBTq6kL+I X-Received: by 2002:a63:4203:: with SMTP id p3-v6mr7036768pga.184.1531943193023; Wed, 18 Jul 2018 12:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531943193; cv=none; d=google.com; s=arc-20160816; b=0LsxBppFpGp8OmELNKfoe/ZSrs/3wYnM/8RM4OqjbSfeM5hFKXJSh0LemzjXhf2BkW tIPQSyg2YPPqGtx/HEP6QnAClnO7tLxuhkzEir4+MQkTgdJWVlZmmde/E4Mm5fg08iPp VymMkXImNSNN2D096nxm0m6uMTiX3WaO3OjmpAQ9FjcjmG4yM8FKgxQKMvDcw+4mjXyG Tt5maBMVGnfFtp9pqr8fMWhBxHP4541/xJO/v3hlqYSTfxmh9sRY6nz6eY6J81MMo9HH 5rUkFPAil1kbydvoL6HAf1mqk4INPPR8+aICAywFTeZViDAo30tfnnf7Hwy8vVKzHAzt FIDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature :arc-authentication-results; bh=Nu0OnSRpSumxEZIdiSlnRveQOPIcVWbUjDO7PFudL1s=; b=J9BEjf/u1pmWxyxSYYdGhcEWTFZtnG87WPN71ztvJOtribsacHsg4PkrY0zLyL7M0w EwxrIMFD7slh19NvlSif0EtzulrL8w1UjFCUt/bgsLDp0DvoaKavYHujqmgJoH+FODSs SfcHvPeWVGX0CWrHPyEFUw5YPZRBwIT8UnQWJKfNXgFkdB6USwiWJEpbD6kgiJ/RgfEF YCgXQjRE4bAkWrDHrebMU7RYFpAo3SowNlPqJXpzYlXflzIJFY+yFOcqEz8tEDQ9FGgN 3gIxicPaqJ3/94IvSQ1yLUU1/7ri+PCWtGr3NAx/S1JwmhNiu5dScedxn2dtBBMaf5A1 hffg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tELiULtI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2-v6si3730677pgp.134.2018.07.18.12.45.55; Wed, 18 Jul 2018 12:46:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tELiULtI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730315AbeGRUXm (ORCPT + 99 others); Wed, 18 Jul 2018 16:23:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:33486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729642AbeGRUXm (ORCPT ); Wed, 18 Jul 2018 16:23:42 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 930D32084E; Wed, 18 Jul 2018 19:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531943059; bh=DH2tZQcJ7vcpfGHoGwolCIws8HK/QeMUcAANbUvg1mE=; h=Subject:From:To:Cc:Date:From; b=tELiULtIZMa47hW1gwxDrVoXX1N2uclc56IDsMg0C2JDCNLb8BgrE470JrHsgwYYV TJFLGfAAwp7djwXKKrIOsFW+OuflyXVv47pdGpQ5Yyqog0VL9ivnD7R1eh5+K1KNRR HvKGOA+tn4ie+Tbf/UB2yqybVkErpDbiargxduAs= Subject: [PATCH v3 0/7] Fix issues and cleanup for ERR_FATAL and ERR_NONFATAL From: Bjorn Helgaas To: Oza Pawandeep Cc: Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 18 Jul 2018 14:44:18 -0500 Message-ID: <153194245964.191586.14782253252654776509.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a v3 of Oza's patches [1]. It's available at [2] if you prefer git. v3 changes: - Add pci_aer_clear_fatal_status() to clear ERR_FATAL bits, only called from pcie_do_fatal_recovery(). Moved to first in series to avoid a window where ERR_FATAL recovery only clears ERR_NONFATAL bits. Visible only inside the PCI core. - Instead of having pci_cleanup_aer_uncorrect_error_status() do different things based on dev->error_state, use this only for ERR_NONFATAL bits. I didn't change the name because it's used by many drivers. - Rename pci_cleanup_aer_error_device_status() to pci_aer_clear_device_status(), make it void, and make it visible only inside the PCI core. - Remove pcie_portdrv_err_handler.slot_reset altogether instead of making it a stub function. Possibly pcie_portdrv_err_handler could be removed completely? [1] https://lkml.kernel.org/r/1529661494-20936-1-git-send-email-poza@codeaurora.org [2] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/?h=pci/06-22-oza-aer --- Bjorn Helgaas (1): PCI/AER: Clear only ERR_FATAL status bits during fatal recovery Oza Pawandeep (6): PCI/AER: Clear only ERR_NONFATAL bits during non-fatal recovery PCI/AER: Factor out ERR_NONFATAL status bit clearing PCI/AER: Remove ERR_FATAL code from ERR_NONFATAL path PCI/AER: Clear device status bits during ERR_FATAL and ERR_NONFATAL PCI/AER: Clear device status bits during ERR_COR handling PCI/portdrv: Remove pcie_portdrv_err_handler.slot_reset drivers/pci/pci.h | 5 ++++ drivers/pci/pcie/aer.c | 47 +++++++++++++++++++++++++++------------- drivers/pci/pcie/err.c | 15 +++++-------- drivers/pci/pcie/portdrv_pci.c | 25 --------------------- 4 files changed, 43 insertions(+), 49 deletions(-)