Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Jul 2018 05:28:12 +0900 (KST)
Message-Id: <20180719.052812.1808217805356135440.davem@davemloft.net>
To:     dave@stgolabs.net
Cc:     herbert@gondor.apana.org.au, akpm@linux-foundation.org,
        tgraf@suug.ch, linux-kernel@vger.kernel.org, dbueso@suse.de,
        netdev@vger.kernel.org
Subject: Re: [PATCH resend -next] lib/rhashtable: consider param->min_size
 when setting initial table size
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180716202613.u6f3l3adrgjvs4wk@linux-r8p5>
References: <20180714062516.30433-1-dave@stgolabs.net>
        <20180716000046.yscgnpr256qhm2qg@gondor.apana.org.au>
        <20180716202613.u6f3l3adrgjvs4wk@linux-r8p5>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Davidlohr Bueso <dave@stgolabs.net>
Date: Mon, 16 Jul 2018 13:26:13 -0700

> rhashtable_init() currently does not take into account the user-passed
> min_size parameter unless param->nelem_hint is set as well. As such,
> the default size (number of buckets) will always be HASH_DEFAULT_SIZE
> even if the smallest allowed size is larger than that. Remediate this
> by unconditionally calling into rounded_hashtable_size() and handling
> things accordingly.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> ---
> Resending per Herbert's request with Cc to netdev.

Applied and queued up for -stable, thanks.