Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1011994imm; Wed, 18 Jul 2018 14:59:04 -0700 (PDT) X-Google-Smtp-Source: AAOMgpenMcSAYtnhn0tcse2CWdWLLhv5goPA4G4Mhbz1Kh/C2SWQwLrzHxEOUEfkrypOKqB/ACnQ X-Received: by 2002:a63:f919:: with SMTP id h25-v6mr7157500pgi.401.1531951144813; Wed, 18 Jul 2018 14:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531951144; cv=none; d=google.com; s=arc-20160816; b=vJjldFl5CmBHmpOe8l3SjdIJ7zYgZuCZy1DsFRjbD+hAcy0j6wVa3CrFVhr2c9p6OE U5CbZR37PxGgfIZ2fCHwGYG4l6IugniBPFoXUn1ZkIdSFtyRBgHKs8f5z5kqtcZ4OSuI ysdneXhKcj6a0KTEJf50+18VdHsQzYrOPTlrx0YIvGLJ+u9vTmKYGSvTQq9imm20ZPIQ McdfNHv+Ye85o+BoaNl+o3uMkQg3N7BUitQQblVlkrwyYwTS3R03597J2Tjsfdzy78PK q/S3UGq5QOrBJAiwdvNQamHkXeU3Ul4tIckz3HjvjjmYR9/Y7fIXXGCblwLbG+lH36EL wLgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=4ker0quClZEgZ5kE8sfGIwDQw5tHDLXhMgyW7gYa9G0=; b=g1Bo53x9paH4vP56sVoK4jDAOOx07z1UAAyYhmvuSIF8NtcWI6EumgLbrFCyUOmcUs Fo7jTuKJ6aSLqj2MH8gHAC8FgJlN7v+gnESbfHVeQLPX57GM+GTj/jJlp27+MJeIXt8N Ia/9zLf1dgcDMOVS2ZkcJWkCZQl5xxtvA/oGbTCZbZoYdtbxhiPG16Iyx0PTerbJUhCo HK/YkDoJwkmvjjvx5WBvLwlBoc8ucP5s7ceM930fZqPAvikj+ehJDDEgSZSidKC6Otgz D4h6yMnyZnqw8cBwDcdn03htYMSFYt2gipugUzSRyzbKQwXwKnUjDpI7/+mkDEnzxLPn rfuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=o9RGiv4y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x21-v6si3482685pgv.669.2018.07.18.14.58.47; Wed, 18 Jul 2018 14:59:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=o9RGiv4y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730094AbeGRWhO (ORCPT + 99 others); Wed, 18 Jul 2018 18:37:14 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:37462 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729230AbeGRWhO (ORCPT ); Wed, 18 Jul 2018 18:37:14 -0400 Received: by mail-qk0-f193.google.com with SMTP id t79-v6so3237577qke.4 for ; Wed, 18 Jul 2018 14:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4ker0quClZEgZ5kE8sfGIwDQw5tHDLXhMgyW7gYa9G0=; b=o9RGiv4y0vhHEG2inTBc8qIvGE+KizE7Db5zpOsll0EtQgVu+/dDkWiHq0Q9tuC1pj 2/thP6va7TBIeHrgQQptHGESNnwaotgins3E3RxUI+zsXvp7kWIXi1fos7xzchs/iSoI GbYrlNAVKdvu8699D3yCX4g6kQ5uh2Ui2AyIQAgzRnSXv3fOM5vmcQEBoQGLVq0EnmGI VlUbYrHBGFtF5dPgRDgSO4oCivjJJiYFNWy5rlWSR4RSF8+sVSJotQK8Vf7iKwhxIsm1 ZPA9tTbvzihNzcsH5o9X0vQSO1CKSvGKcZsPW20Kv1sVqllaRkNurDa3w0EZAyTpZ68h OsPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4ker0quClZEgZ5kE8sfGIwDQw5tHDLXhMgyW7gYa9G0=; b=QFt/Ga/Av6s2Cry2S83+EF0Gn9WCi74eD2+6rcJZBqZXZtwtoHFNHuJCqZNSpgty5n QdwB62J116+jiGtrNy8S69PxjZATj9M90+qfW8hbvMpmY1bU6bUKNPl1kuh4DkAAj2ms tj9w3qNbwB/WLwkrdyE8Eq9E3OUCv7lxS7OK3iZoF/+wAtpvfQ/lgIJYicqY/8nm2Qkt UEoIHDOYocgtwWMXEZeGqcbb9JQqFn0piXRvbYfqbprjQxN3oFTHceiONDQhmdtNUkAh QRgELhO1VnqtNVZFTAayXn+cOOXs4s1M1Np+mR44EBQU0VtrUrTs//rJbBXV4oOuWXOs xEtQ== X-Gm-Message-State: AOUpUlH47f0nz4BHC0RJAawyMOlNaMYQj7/8RpAoOWZ4866YA3bq8oC2 hEQ8w82TXCcvkDiWaciOqdI8ag== X-Received: by 2002:a37:953:: with SMTP id 80-v6mr7089513qkj.331.1531951040819; Wed, 18 Jul 2018 14:57:20 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::2:7eca]) by smtp.gmail.com with ESMTPSA id v88-v6sm4510813qkv.63.2018.07.18.14.57.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 14:57:19 -0700 (PDT) Date: Wed, 18 Jul 2018 18:00:06 -0400 From: Johannes Weiner To: Peter Zijlstra Cc: Ingo Molnar , Andrew Morton , Linus Torvalds , Tejun Heo , Suren Baghdasaryan , Vinayak Menon , Christopher Lameter , Mike Galbraith , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 08/10] psi: pressure stall information for CPU, memory, and IO Message-ID: <20180718220006.GC2838@cmpxchg.org> References: <20180712172942.10094-1-hannes@cmpxchg.org> <20180712172942.10094-9-hannes@cmpxchg.org> <20180717141614.GE2494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180717141614.GE2494@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 04:16:14PM +0200, Peter Zijlstra wrote: > On Thu, Jul 12, 2018 at 01:29:40PM -0400, Johannes Weiner wrote: > > +/* Tracked task states */ > > +enum psi_task_count { > > + NR_RUNNING, > > + NR_IOWAIT, > > + NR_MEMSTALL, > > + NR_PSI_TASK_COUNTS, > > +}; > > > +/* Resources that workloads could be stalled on */ > > +enum psi_res { > > + PSI_CPU, > > + PSI_MEM, > > + PSI_IO, > > + NR_PSI_RESOURCES, > > +}; > > These two have mem and iowait in different order. It really doesn't > matter, but my brain stumbled. No problem, I swapped them around for v3.