Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1072103imm; Wed, 18 Jul 2018 16:14:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfjcDq5zuVXiCuOztDXWDhy5sjKM8nNHwji8Sc1OolvOjKqmHX/MG3j6jVl1SH6WQo2DdlJ X-Received: by 2002:a17:902:381:: with SMTP id d1-v6mr7723476pld.309.1531955672108; Wed, 18 Jul 2018 16:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531955672; cv=none; d=google.com; s=arc-20160816; b=TWdcOviUz0Rq9cA1VSzBjua9FVq85lv2vAhozfC8L8y11d7mGYGH9NRVylOQ1b2E12 pvVW5Wo+s7Xu7dW6x/NNScfsl+WnX3f46JnnTvjxW+IrXaOI4rW/wo5v+0xY8VYBwQqJ anIrPu2fddfWx+qG94qx4AgSdImvDqBqPQC4ImzXD0+MN3oGLxAmUH9amoICQyPOairh TThNlxOuzR1BlIIqSn+8Dl9aHww0hP5w/IwOEnwSLS/VH12NnDMRAYOvxJlnO/5GdlSV TyVP0vbNgV47PmkezXGledkqQYbeA0iD6MD7Fx6B6RGtpJ7PDytKOpDWcKwKbqAQETck gimQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=oG1yvYin7U2bOXXQhg3Pky6W/f/xDbDGzjP2JRHhfjQ=; b=akU3MsD26kiaGM58wMXTCct/Tq+/gRvzrp4temwkicBZeLEKUtUYjWZcVQr+/+sKal qeKKrPtecs6LfKXfL+M4hdjyU+HvMCiFruduj2941so0V2sf+kHFUpeh8ac8SsVYQb7X ZcP1+RCNpIvcrUgYE/BrP2RkSi4bIawdJaYV1pVp9EdN8AUsw9IRVPq00K9FHJjfNXzW 4HdryNPOHrhlssYczr0M45QqJhw04bHmaVe8HD6PfFAw7qAZkogMAOEd2r19r7c9SBHZ wL9Ol5j4KBiCZCoBuDslaJjyLI8n8j8lWHTLeMCy4UxlouDrnspbYN6GtKhQGppZTuVQ 5N9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u195-v6si4472314pgb.443.2018.07.18.16.14.17; Wed, 18 Jul 2018 16:14:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730521AbeGRXxN (ORCPT + 99 others); Wed, 18 Jul 2018 19:53:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45544 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726992AbeGRXxM (ORCPT ); Wed, 18 Jul 2018 19:53:12 -0400 Received: from localhost (unknown [172.58.43.198]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B245814799E73; Wed, 18 Jul 2018 16:13:01 -0700 (PDT) Date: Thu, 19 Jul 2018 08:13:00 +0900 (KST) Message-Id: <20180719.081300.1581730029693790076.davem@davemloft.net> To: brgl@bgdev.pl Cc: nsekhar@ti.com, khilman@kernel.org, linux@armlinux.org.uk, grygorii.strashko@ti.com, srinivas.kandagatla@linaro.org, lukas@wunner.de, robh@kernel.org, f.fainelli@gmail.com, dan.carpenter@oracle.com, ivan.khoronzhuk@linaro.org, david@lechnology.com, gregkh@linuxfoundation.org, andrew@lunn.ch, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, bgolaszewski@baylibre.com Subject: Re: [PATCH 2/5] net: add an info message to eth_platform_get_mac_address() From: David Miller In-Reply-To: <20180718161035.7005-3-brgl@bgdev.pl> References: <20180718161035.7005-1-brgl@bgdev.pl> <20180718161035.7005-3-brgl@bgdev.pl> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Jul 2018 16:13:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Date: Wed, 18 Jul 2018 18:10:32 +0200 > > + dev_info(dev, "read MAC address from %s\n", from); > ether_addr_copy(mac_addr, addr); > return 0; Ugh, please don't do this. We probe various bits of information from various sources during driver probe, and none of them are more or less important than the MAC address. So singling this out for log info output is really not such a great idea. Thank you.