Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1083444imm; Wed, 18 Jul 2018 16:30:24 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc8Rc/b30WncgytSzhWsx4D4FhkUicZt7jID7AqO14t4a0dUJInAVxqzjs8kTizw3cqZZ/B X-Received: by 2002:a63:7007:: with SMTP id l7-v6mr7661750pgc.206.1531956624905; Wed, 18 Jul 2018 16:30:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531956624; cv=none; d=google.com; s=arc-20160816; b=lySIgFScj4cFYqMcvlIAMl9++J383lbDuJE7fO90OQ1hCMmgHgbHYiAHuOT6S2qI8S d8TegHv/IoQ1FQSA+NGkolJYs0a1hK7UAu2ArMVVT6++/UkC43Hku5Sv7EA52bJPADrO g94yDFJO91ZAgqVRkTrFRMAVc/hU0wsYl22XrvNqJ5jClBdqvtRUMOc01fYFmz9W6rU3 dPoiuZrBfpgj5ichps/9ssewVISoaL4jX3Ubfy9aFZUmqzyhFmhjPRZ9iR6kBsM8Ml70 HvXwLMhhzAIluHvskz3mVuRDpTazjqKV7kh0Jw/G32BXEHVyv8IHzgs4y5TGkQLQzcJO JVdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=3YYYfbChG65AfvNvFBLJiPWrYWWTCb2957knomK/Ai4=; b=ki5VdftXNhoG4PVDeT/k15gZ9z4LbXEi9OHFqpAYNSqFHlFq7U/lhv+i+b/tQTpTve OSnvtn5OMpPG5OAka5piOUprN5srCwJtNDlcRA2X22tAaTOfd20JVAj3g863av/YArt7 fzR/cEEq+RAJDJ/14R/jl29KWlzXo2sAR1Kfn8gl7snSJa9oHvG30VGRfDHb3DETaRGv 1H2J3GJcS92KUm1AiPz+XNZyNqLi6s7lGQSH5TOrm/4cOj17f6aANg896H62XVas+HE4 bykJC4LPAB5LI8qUfZ/hoZO2CcFM74Pz4F/31j2ywgK+HRiV50nfEwlF5c3SkaTPfw26 w0dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qo7VnMc2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 28-v6si4653259pgk.111.2018.07.18.16.30.09; Wed, 18 Jul 2018 16:30:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qo7VnMc2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730846AbeGSAJt (ORCPT + 99 others); Wed, 18 Jul 2018 20:09:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:48184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728304AbeGSAJt (ORCPT ); Wed, 18 Jul 2018 20:09:49 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61B682084E; Wed, 18 Jul 2018 23:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531956575; bh=hfBF04FkaF+8jRfxk9yETUJz7z/XJxZdKmGvWCYinoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qo7VnMc2jY2Q4l6bDDOEoed0euZ7vXw2HgPWyC1t4aOpbbTnsF5SRDcH0qU1Vx1Jx XZgmw92j2Bt3vdNS7o3tQeYn5N+JslEI6ZkNxrMAAh8jzyrg+pa3WJO2Kk41QNknRD j2zj0xUUzOaNAP71ZV/La3GllYcFvy1fkNC0cNqk= Date: Wed, 18 Jul 2018 18:29:34 -0500 From: Bjorn Helgaas To: Sinan Kaya Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , open list Subject: Re: [PATCH V5 5/6] PCI: Deprecate pci_reset_bus() and pci_reset_slot() functions Message-ID: <20180718232934.GK128988@bhelgaas-glaptop.roam.corp.google.com> References: <1530572336-20296-1-git-send-email-okaya@codeaurora.org> <1530572336-20296-6-git-send-email-okaya@codeaurora.org> <20180718223027.GI128988@bhelgaas-glaptop.roam.corp.google.com> <3d664a22-7362-07ec-584d-b38829a22ba2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d664a22-7362-07ec-584d-b38829a22ba2@kernel.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2018 at 03:36:29PM -0700, Sinan Kaya wrote: > On 7/18/2018 3:30 PM, Bjorn Helgaas wrote: > > On Mon, Jul 02, 2018 at 06:58:54PM -0400, Sinan Kaya wrote: > > > pci_reset_bus() and pci_reset_slot() functions are not being used by > > > any code. Remove them from the kernel in favor of pci_try_reset_bus() > > > and pci_try_reset_slot() functions. > > > > > > Signed-off-by: Sinan Kaya > > > --- > > > drivers/pci/pci.c | 55 ++--------------------------------------------------- > > > include/linux/pci.h | 2 -- > > > 2 files changed, 2 insertions(+), 55 deletions(-) > > > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > > index a31e6db..7e3f2e9 100644 > > > --- a/drivers/pci/pci.c > > > +++ b/drivers/pci/pci.c > > > @@ -4784,9 +4784,9 @@ int pci_probe_reset_slot(struct pci_slot *slot) > > > EXPORT_SYMBOL_GPL(pci_probe_reset_slot); > > > /** > > > - * pci_reset_slot - reset a PCI slot > > > + * __pci_try_reset_slot - Try to reset a PCI slot > > > * @slot: PCI slot to reset > > > - * > > > + *` > > > > Is this "*`" intentional or a typo? I can't find it in kernel-doc.rst > > (but it's full of ` and maybe I missed it). > > Typo. Great, I fixed it.