Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v14 20/25] x86/tsc: calibrate tsc only once
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Pavel Tatashin <pasha.tatashin@oracle.com>,
        <steven.sistare@oracle.com>, <daniel.m.jordan@oracle.com>,
        <linux@armlinux.org.uk>, <schwidefsky@de.ibm.com>,
        <heiko.carstens@de.ibm.com>, <john.stultz@linaro.org>,
        <sboyd@codeaurora.org>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <hpa@zytor.com>, <peterz@infradead.org>, <prarit@redhat.com>,
        <feng.tang@intel.com>, <pmladek@suse.com>,
        <gnomes@lxorguk.ukuu.org.uk>, <linux-s390@vger.kernel.org>,
        <boris.ostrovsky@oracle.com>, <jgross@suse.com>,
        <pbonzini@redhat.com>
References: <20180718022211.6259-1-pasha.tatashin@oracle.com>
 <20180718022211.6259-21-pasha.tatashin@oracle.com>
 <4f0933a3-27b4-5468-83f5-af9b90842812@cn.fujitsu.com>
 <alpine.DEB.2.21.1807190818110.1689@nanos.tec.linutronix.de>
From:   Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <82b363bb-de81-0ddf-cb0d-83945eba72f0@cn.fujitsu.com>
Date:   Thu, 19 Jul 2018 14:48:28 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1807190818110.1689@nanos.tec.linutronix.de>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Thomas,

At 07/19/2018 02:25 PM, Thomas Gleixner wrote:
> On Thu, 19 Jul 2018, Dou Liyang wrote:
>> At 07/18/2018 10:22 AM, Pavel Tatashin wrote:
>>> +		(unsigned long)cpu_khz % KHZ);
>>>      	if (cpu_khz != tsc_khz) {
>>>    		pr_info("Detected %lu.%03lu MHz TSC",
>>> -			(unsigned long)tsc_khz / 1000,
>>> -			(unsigned long)tsc_khz % 1000);
>>> +			(unsigned long)tsc_khz / KHZ,
>>> +			(unsigned long)tsc_khz % KHZ);
>>> +	}
>>
>> this curly brackets can be removed
> 
> No. They want to stay, really.
> 
>      https://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos
> 
> The pr_info() is a multiline statement due to the line breaks.
> 

I see, I??ll keep that in mind.

Thanks,

	dou