Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1425461imm; Thu, 19 Jul 2018 01:10:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcJ6/FfcnmiI+6mpVojdTSPef/0hmZqUoWj4iKH/X/x4IEZPJLYQMdeKzs5lkU7Njrz2IIs X-Received: by 2002:a62:f610:: with SMTP id x16-v6mr8613800pfh.169.1531987815499; Thu, 19 Jul 2018 01:10:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531987815; cv=none; d=google.com; s=arc-20160816; b=rzwlymFF5OOGWhCilpOapn0YrnvKBTChF5zqaWa3KlOZvEKbQEer+5tkH6iaeeEx8O V7XmoOsLlJS2zoBqTcq5zW/Glh+8gCAidZFt3gtUyi8PhS/kUwySjhED2cKgQT6KcOqb b/y94tAzQxp8Rys/7/uytkLuKU9kN1rZ8igeZnAUSDI0qPs6PqTZKPoGpouYom6nBvbQ S78MbrqZMzWLGwVw2nXm/OqcNjWUZfEd1IwXPUSf3FxSkmPMSxvtOYzuJ07dc880oZK/ woFIEH5IZdxqqbzQL5nVPhN5TQJx9FW5smuOn4jdMEvS8Q2uUzAcehl0dlLvCzTY4eUg MhTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=eXkgK5xDg2hpd9zMd4dLFg5MTJgZvFi8Ll15ynCGIaI=; b=bMksGthqP1CQJXRLqrKsOPZT4SRdpi+FjjxOskI5zWl/Cq5DUrYJKJPQqDT96xuaqf xB9ct97mtJFcFNNCeXqRAgDTFodeLFLBEt1jrvaiFrB9t5nM5Ji02UwmAFRc6j6rWvWC 72QwEefmQddPmbJf1WCboRXianU8g0WgCMx/RInQt902fFmLOWCcrhVGvhlBP12pROyH 2XPwCkTXl1dPiwdhlwCHSEcwI4q0RLovQ0ZoaeuOapyKxIdm3c1ZXS0U4c4nfPLVslMA kf7LuR/gcDe/sdDalNE94J5UYvRJg+Df6sPA3d+GgIRbSRLBpspimtqrXkxq/ael0c9d BKxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i61-v6si5103269plb.138.2018.07.19.01.10.01; Thu, 19 Jul 2018 01:10:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731577AbeGSIvR (ORCPT + 99 others); Thu, 19 Jul 2018 04:51:17 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731391AbeGSIvQ (ORCPT ); Thu, 19 Jul 2018 04:51:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F13440201CA; Thu, 19 Jul 2018 08:09:20 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-116.rdu2.redhat.com [10.10.120.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A2D72026D6B; Thu, 19 Jul 2018 08:09:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180718154637.31878-1-mszeredi@redhat.com> References: <20180718154637.31878-1-mszeredi@redhat.com> To: Miklos Szeredi Cc: dhowells@redhat.com, Al Viro , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] vfs: make open_with_fake_path() not contribute to nr_files MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18288.1531987758.1@warthog.procyon.org.uk> Date: Thu, 19 Jul 2018 09:09:18 +0100 Message-ID: <18289.1531987758@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 19 Jul 2018 08:09:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 19 Jul 2018 08:09:20 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > Stacking file operations in overlay will store an extra open file for each > overlay file opened. > > The overhead is just that of "struct file" which is about 256bytes, because > overlay already pins an extra dentry and inode when the file is open, which > add up to a much larger overhead. > > For fear of breaking working setups, don't start accounting the extra file. Sounds useful for cachefiles too, though Christoph Hellwig objected strongly last time I tried this, so you might want to check with him directly. David