Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.60.100 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02;
Subject: Re: [PATCH v10 10/10] drivers: clk: Add ZynqMP clock driver
To:     Jolly Shah <jolly.shah@xilinx.com>, <ard.biesheuvel@linaro.org>,
        <mingo@kernel.org>, <gregkh@linuxfoundation.org>,
        <matt@codeblueprint.co.uk>, <sudeep.holla@arm.com>,
        <hkallweit1@gmail.com>, <keescook@chromium.org>,
        <dmitry.torokhov@gmail.com>, <mturquette@baylibre.com>,
        <sboyd@codeaurora.org>, <michal.simek@xilinx.com>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <linux-clk@vger.kernel.org>
CC:     <rajanv@xilinx.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Tejas Patel <tejasp@xilinx.com>,
        Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
        Jolly Shah <jollys@xilinx.com>
References: <1531857547-16652-1-git-send-email-jollys@xilinx.com>
 <1531857547-16652-11-git-send-email-jollys@xilinx.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <6dadc5a6-7bc1-0e37-4df6-0278d9046c96@xilinx.com>
Date:   Thu, 19 Jul 2018 12:30:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1531857547-16652-11-git-send-email-jollys@xilinx.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2018 10:30:45.1854
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 21b28cf2-2f71-4516-001d-08d5ed62afba
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1913
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephen and Mike,

On 17.7.2018 21:59, Jolly Shah wrote:
> From: Jolly Shah <jolly.shah@xilinx.com>
> 
> This patch adds CCF compliant clock driver for ZynqMP.
> Clock driver queries supported clock information from
> firmware and regiters pll and output clocks with CCF.
> 
> Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> Signed-off-by: Tejas Patel <tejasp@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Jolly Shah <jollys@xilinx.com>
> ---
>  drivers/clk/Kconfig                  |   1 +
>  drivers/clk/Makefile                 |   1 +
>  drivers/clk/zynqmp/Kconfig           |  10 +
>  drivers/clk/zynqmp/Makefile          |   4 +
>  drivers/clk/zynqmp/clk-gate-zynqmp.c | 144 +++++++
>  drivers/clk/zynqmp/clk-mux-zynqmp.c  | 141 +++++++
>  drivers/clk/zynqmp/clk-zynqmp.h      |  68 ++++
>  drivers/clk/zynqmp/clkc.c            | 719 +++++++++++++++++++++++++++++++++++
>  drivers/clk/zynqmp/divider.c         | 217 +++++++++++
>  drivers/clk/zynqmp/pll.c             | 335 ++++++++++++++++
>  include/linux/firmware/xlnx-zynqmp.h |   1 +
>  11 files changed, 1641 insertions(+)
>  create mode 100644 drivers/clk/zynqmp/Kconfig
>  create mode 100644 drivers/clk/zynqmp/Makefile
>  create mode 100644 drivers/clk/zynqmp/clk-gate-zynqmp.c
>  create mode 100644 drivers/clk/zynqmp/clk-mux-zynqmp.c
>  create mode 100644 drivers/clk/zynqmp/clk-zynqmp.h
>  create mode 100644 drivers/clk/zynqmp/clkc.c
>  create mode 100644 drivers/clk/zynqmp/divider.c
>  create mode 100644 drivers/clk/zynqmp/pll.c

DT binding was reviewed by Stephen but I can't see any review for the
driver itself. Should I wait for your review or do you want to take
binding doc 09/10 and 10/10 separately or this can go via arm-soc tree?

Thanks,
Michal