Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1561844imm; Thu, 19 Jul 2018 04:05:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdy509XaE8sNkf6ZumTla66zXVZgAXsSz2twwACU1iHwL0eerFK3cZpbSmBqn2N95OsLI6b X-Received: by 2002:a17:902:280b:: with SMTP id e11-v6mr9649355plb.298.1531998339047; Thu, 19 Jul 2018 04:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531998339; cv=none; d=google.com; s=arc-20160816; b=0E4kYB8iH1DdqfJ3soy7ZuVVQftuo1frTAyCV43NucMGyBZ9tJ4495C9VkylKNX31O 35HH6OIBteOBZSAogmWmFfTfi+TK7sLq2RW1vNxRq3fO7DkLsSOdsEXh0jEQCMlpe4f7 +k8u69c0szOhPmIMgJ5pMu1/K73khVr6pQxxtizrp5WSkvbhWk6whe5U4wCsUJXWCOtD x4bkLLQZKakhGgSp5kDicaAo7XN4fL0twhOBQvHEUL3Iw0NwC3lSzgBdiSXs6naaeX4h DiitW8xiWaVmuWz/DtzCpHNz4Ext1ROdTGJcCAqprY62e38BI822p9CsjU+tvQatzDrv jDDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=nAtM5BgfINA07rcZYmLSc7ETd0aRGj+aVtAXFgl6Aos=; b=cJ+sRbUjYGxL00s+P+8YB7ffK6QS1BQsgNGB7oVB9smVAiLB52xyrB2BRcdkKhU97C mvebike9QmneptlKnoR/r8I24BfnrXRZ4wvajg8KQCplo02U+ksSbdntx1iaj7zjly1z holB+AaA0FDCXp7pb5J5oYJmOrKzCWMQrJWR+0PJkupUo6EMc9Jpz82UBFMvYwephLhO xYoqAIQC5pjyakCLZOvNHXXh3C98fz7BJQ/sHO3RiTNMg7Kv+LIdhwKzkxmsJgvIWIWN D9NX5aLaOFad5PHyiQt8b1KlTF2ySoGpYLt09pGH6U4pAFOx+DvgiGCcWokbvHtr2fht nAIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 4-v6si5384571pla.311.2018.07.19.04.05.05; Thu, 19 Jul 2018 04:05:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730782AbeGSLq7 (ORCPT + 99 others); Thu, 19 Jul 2018 07:46:59 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47790 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730316AbeGSLq7 (ORCPT ); Thu, 19 Jul 2018 07:46:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B86F7A9; Thu, 19 Jul 2018 04:04:20 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.207.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7DD643F246; Thu, 19 Jul 2018 04:04:18 -0700 (PDT) Date: Thu, 19 Jul 2018 12:04:13 +0100 From: Lorenzo Pieralisi To: Gustavo Pimentel Cc: bhelgaas@google.com, joao.pinto@synopsys.com, jingoohan1@gmail.com, kishon@ti.com, adouglas@cadence.com, jesper.nilsson@axis.com, shawn.lin@rock-chips.com, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v14 00/12] Add MSI-X support on pcitest tool Message-ID: <20180719110412.GA9213@e107981-ln.cambridge.arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 19, 2018 at 10:32:10AM +0200, Gustavo Pimentel wrote: > Patch series made against Lorenzo's master branch. > > Fix EP link notification implementation. > > Add MSI-X support on pcitest tool. > > Add new callbacks methods and handlers to trigger the MSI-X interrupts > on the EP DesignWare IP driver. > > Allow to set/get MSI-X EP maximum capability number. > > Rework on set/get and triggering MSI methods on EP DesignWare IP driver. > > Add a new input parameter (msix) to pcitest tool to test MSI-X feature. > > Update the pcitest.sh script to support MSI-X feature tests. > > Update related documentation accordingly. > > Gustavo Pimentel (12): > PCI: dwc: Fix EP link notification implementation > PCI: endpoint: Add MSI-X interfaces > PCI: Update xxx_pcie_ep_raise_irq() and pci_epc_raise_irq() signatures > PCI: dwc: Add MSI-X callbacks handler > PCI: dwc: Rework MSI callbacks handler > PCI: dwc: Add legacy interrupt callback handler > pci-epf-test/pci_endpoint_test: Cleanup PCI_ENDPOINT_TEST memspace > pci-epf-test/pci_endpoint_test: Use irq_type module parameter > pci-epf-test/pci_endpoint_test: Add MSI-X support > pci_endpoint_test: Add 2 ioctl commands > tools: PCI: Add MSI-X support > PCI: endpoint: Add MSI set maximum restriction > > .../PCI/endpoint/function/binding/pci-test.txt | 2 + > Documentation/PCI/endpoint/pci-endpoint.txt | 4 +- > Documentation/PCI/endpoint/pci-test-function.txt | 29 ++- > Documentation/PCI/endpoint/pci-test-howto.txt | 30 ++- > Documentation/ioctl/ioctl-number.txt | 1 + > Documentation/misc-devices/pci-endpoint-test.txt | 6 + > drivers/misc/pci_endpoint_test.c | 290 ++++++++++++++++----- > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > drivers/pci/controller/dwc/pcie-artpec6.c | 2 +- > drivers/pci/controller/dwc/pcie-designware-ep.c | 210 +++++++++++++-- > drivers/pci/controller/dwc/pcie-designware-plat.c | 11 +- > drivers/pci/controller/dwc/pcie-designware.h | 29 ++- > drivers/pci/controller/pcie-cadence-ep.c | 3 +- > drivers/pci/controller/pcie-rockchip-ep.c | 2 +- > drivers/pci/endpoint/functions/pci-epf-test.c | 86 ++++-- > drivers/pci/endpoint/pci-ep-cfs.c | 24 ++ > drivers/pci/endpoint/pci-epc-core.c | 68 ++++- > include/linux/pci-epc.h | 16 +- > include/linux/pci-epf.h | 1 + > include/uapi/linux/pcitest.h | 3 + > tools/pci/pcitest.c | 51 +++- > tools/pci/pcitest.sh | 15 ++ > 22 files changed, 735 insertions(+), 150 deletions(-) Applied to pci/dwc for v4.19, thanks for the series and the thorough review ! Lorenzo