Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1664946imm; Thu, 19 Jul 2018 05:58:30 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfYcp6Xj8YIWEppchUpbdnT1A0WtPoXEQb7jDhw7XYa6KxpNyfxFJ/o4vGpq3Y39g2dui3c X-Received: by 2002:a65:4c02:: with SMTP id u2-v6mr10173374pgq.364.1532005110906; Thu, 19 Jul 2018 05:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532005110; cv=none; d=google.com; s=arc-20160816; b=IGSWzdZtEbYbSAR9HYNgwqlIF8nGywplU1x/kJWaLmiONKcHYKPY8jOIiEMEJeHoQo 13yTUX4UQ1TKb7jBs3reklvfFLSX9t3qIfDW3KkNob5swbtRlKwhmAPmlk3WpIYMkwss 6hfeZUlk/Jds/Bk1d9gAIWbyVowESC3n2UKYRDN6BcGio2PfWz5/3kMHGul1csAXDYtH LZLzrUG1LOeGqtPP4rpvSaoHpjgiigNeyfN9byNLf0KfUWdXDerAjzb7OowipB/RRPOJ 6r7lYFv0fFRLM7/U1la+40vt000sVPWdiqmyiu3pL/rkUW5S82BgLg3GZfBsG0gR5++1 u0YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=aqD8eDnO2LcHaLjon8E2opomA3Ye3ujWt8xxAKkGCT0=; b=w+GCGSLRjqZCRg0I4s/oFV1DAMLOfkzJCNR0PfrYjunOcjOJq+fgJVyzfS0YDV8Fy7 cvf9RVVN3SgMOXbaS78PfzWpKSpzn2gdbrIFqvH+3t/oPsX3uG0EZsyWIcAPwoxLA8ld QYO8F7DHuAPPIIyb9ojSyMwrXf2Hwx/pc+tcERHRc9+o2cEuYVpXOkZyzyqwCRD29mXW 3FOik/vquOGsQa2c+B3jhg+wDNki2LM8niKuCa2GwDOpRjr0aLNQow3fqVjRSu+c1Txk jIGBanKEcG48QDiaQm4AvKICzahar6UbxvER2+ujIPUVfFTcqpW2lJTC9Q/1OTXboj2T q6Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eln+POS1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5-v6si5690520pla.87.2018.07.19.05.58.16; Thu, 19 Jul 2018 05:58:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=eln+POS1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731655AbeGSNjh (ORCPT + 99 others); Thu, 19 Jul 2018 09:39:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:34416 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731110AbeGSNjh (ORCPT ); Thu, 19 Jul 2018 09:39:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aqD8eDnO2LcHaLjon8E2opomA3Ye3ujWt8xxAKkGCT0=; b=eln+POS1V/c2QXRI8XjOmLnXZ XIaGRGTrFhLLdnXyWsAHJ4oE3BC/FFHjgheSni7qkYDkjfFxw+VwXQzNKVsTr8/l3RKwdE0m87xOA uk28zpqxNIpaS3PnoCCcXU85RomOLl5YlBPetvmF3VerULuP439zKP2aHJbSbgNf/Gt+5WX42kifM QHoMkH96a2LPA+em4c0faVrHJMtITgzrh20GIwos4F5OK3nn/f3/MuotXajs6mZrVSrZMwIZTw7JR Ig+xRuF0tpQZY+gHirDIAIeYZKV6olM59qfyBxwl1k6xZqcNVlJw0Z/pHPEDPyK1LfAYwmzbxMthV Rso4in/6Q==; Received: from [96.72.186.57] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fg8Tz-0006Qu-JO; Thu, 19 Jul 2018 12:56:35 +0000 From: Christoph Hellwig To: Richard Kuo Cc: linux-hexagon@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] hexagon: remove the sync_single_for_cpu DMA operation Date: Thu, 19 Jul 2018 05:56:33 -0700 Message-Id: <20180719125635.824-2-hch@lst.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180719125635.824-1-hch@lst.de> References: <20180719125635.824-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hexagon does all the required cache maintainance at dma map time, and none at unmap time. It thus has to implement sync_single_for_device to match the map cace for buffer reuse, but there is no point in doing another invalidation in the sync_single_cpu_case, which in terms of cache maintainance is equivalent to the unmap case. Signed-off-by: Christoph Hellwig --- arch/hexagon/kernel/dma.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/hexagon/kernel/dma.c b/arch/hexagon/kernel/dma.c index 77459df34e2e..d2b717f352f4 100644 --- a/arch/hexagon/kernel/dma.c +++ b/arch/hexagon/kernel/dma.c @@ -181,13 +181,6 @@ static dma_addr_t hexagon_map_page(struct device *dev, struct page *page, return bus; } -static void hexagon_sync_single_for_cpu(struct device *dev, - dma_addr_t dma_handle, size_t size, - enum dma_data_direction dir) -{ - dma_sync(dma_addr_to_virt(dma_handle), size, dir); -} - static void hexagon_sync_single_for_device(struct device *dev, dma_addr_t dma_handle, size_t size, enum dma_data_direction dir) @@ -205,7 +198,6 @@ const struct dma_map_ops hexagon_dma_ops = { .free = hexagon_free_coherent, .map_sg = hexagon_map_sg, .map_page = hexagon_map_page, - .sync_single_for_cpu = hexagon_sync_single_for_cpu, .sync_single_for_device = hexagon_sync_single_for_device, .mapping_error = hexagon_mapping_error, }; -- 2.18.0