Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1745639imm; Thu, 19 Jul 2018 07:14:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeAL5Tx60gOyh7Cx5/T/gvE/BoL1sESmQ7+9PdRAwN9uP6Ri/u0KpP1hZBL0nW84a7jV4bm X-Received: by 2002:a17:902:1703:: with SMTP id i3-v6mr10096343pli.263.1532009689799; Thu, 19 Jul 2018 07:14:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532009689; cv=none; d=google.com; s=arc-20160816; b=c41ip716mMIycHeDcrr8DzyW5r8ws7McU/XE0UksDTZ1UVlbT3rHXPcFwHd24ha/d4 ag+QCXhAdx/X7/MpBEFCOUD7xCqHUrOauwllt241h+rzVHmfN+rJX6Tswx5Ur+Bxs3c/ dGYQaeXYRKVfwDrecDk/8P3SomPY3S7b3yteh042j7wm8/CQht0TZGdlzI5Rnye1/JSV rr1rKEvktesqM+4j0S/Sssdj7RuvsYB2MyNlUZat3FXfJHesX/1a9bxy5Qgn8OUssEcQ /QeccmuKKjRrcKx3K7x6VSvZ1x8InDkN1AtWydaN5lNpq63ImR9+Apij8OLsSIf4bN+9 6FNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:cc:references:to:subject :arc-authentication-results; bh=mZtnMCOsqJtJcQqCp312AihLdZug6m4BFr2LE7MBoOA=; b=weButIFGAkZFC6rWOXdsCot6/1ItrIERSQe85peY9slTUmZF2Hyp1xvHDa9xyqqbIZ LUVJNj95+h2xVPQWaGytb0LVT/SOtC51KIhKf+QjAyoAbuDWIL7VcN7vcggd7xh6RiWJ FX9S3E7/rcYXpPmPwrxAfdzgI76UYjZERwl8A4v6xgWyB8BlTQT9qXyx0YRlJ3CXxm+M zxJtidczHHjiVH27U1OZ9/Kxykgd3tTSwKC/K2M9ULlXDQfLVdpw/7JDONbwo1dlhVXZ 4vRlQuNp6MfZqRRsiNkO1iTjh6zS5ce5k3sCxT19F607REUxJdw+FkmkdGnphq9+s3+i 8OTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2-v6si6257981pff.117.2018.07.19.07.14.34; Thu, 19 Jul 2018 07:14:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731603AbeGSO5Q (ORCPT + 99 others); Thu, 19 Jul 2018 10:57:16 -0400 Received: from mga18.intel.com ([134.134.136.126]:35038 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731110AbeGSO5Q (ORCPT ); Thu, 19 Jul 2018 10:57:16 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 07:13:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,374,1526367600"; d="scan'208";a="58136225" Received: from heli-mobl.ccr.corp.intel.com (HELO [10.252.187.17]) ([10.252.187.17]) by orsmga008.jf.intel.com with ESMTP; 19 Jul 2018 07:13:41 -0700 Subject: Re: [PATCHv5 06/19] mm/khugepaged: Handle encrypted pages To: "Kirill A. Shutemov" References: <20180717112029.42378-1-kirill.shutemov@linux.intel.com> <20180717112029.42378-7-kirill.shutemov@linux.intel.com> <20180719085901.ebdciqkjpx6hy4xt@kshutemo-mobl1> Cc: "Kirill A. Shutemov" , Ingo Molnar , x86@kernel.org, Thomas Gleixner , "H. Peter Anvin" , Tom Lendacky , Kai Huang , Jacob Pan , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Thu, 19 Jul 2018 07:13:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180719085901.ebdciqkjpx6hy4xt@kshutemo-mobl1> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2018 01:59 AM, Kirill A. Shutemov wrote: > On Wed, Jul 18, 2018 at 04:11:57PM -0700, Dave Hansen wrote: >> On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: >>> khugepaged allocates page in advance, before we found a VMA for >>> collapse. We don't yet know which KeyID to use for the allocation. >> >> That's not really true. We have the VMA and the address in the caller >> (khugepaged_scan_pmd()), but we drop the lock and have to revalidate the >> VMA. > > For !NUMA we allocate the page in khugepaged_do_scan(), well before we > know VMA. Ahh, thanks for clarifying. That's some more very good information about the design and progression of your patch that belongs in the changelog. >>> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >>> index 5ae34097aed1..d116f4ebb622 100644 >>> --- a/mm/khugepaged.c >>> +++ b/mm/khugepaged.c >>> @@ -1056,6 +1056,16 @@ static void collapse_huge_page(struct mm_struct *mm, >>> */ >>> anon_vma_unlock_write(vma->anon_vma); >>> >>> + /* >>> + * At this point new_page is allocated as non-encrypted. >>> + * If VMA's KeyID is non-zero, we need to prepare it to be encrypted >>> + * before coping data. >>> + */ >>> + if (vma_keyid(vma)) { >>> + prep_encrypted_page(new_page, HPAGE_PMD_ORDER, >>> + vma_keyid(vma), false); >>> + } >> >> I guess this isn't horribly problematic now, but if we ever keep pools >> of preassigned-keyids, this won't work any more. > > I don't get this. What pools of preassigned-keyids are you talking about? My point was that if we ever teach the allocator or something _near_ the allocator to keep pools of pre-zeroed and/or pre-cache-cleared pages, this approach will need to get changed otherwise we will double-prep pages. My overall concern with prep_encrypted_page() in this patch set is that it's inserted pretty ad-hoc. It seems easy to miss spots where it should be. I'm also unsure of the failure mode and anything we've done to ensure that if we get this wrong, we scream clearly and loudly about what happened. Do we do something like that?