Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1775894imm; Thu, 19 Jul 2018 07:42:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfVaDDmKvsfw94ogk31VZLvoKOXIw+2NzAzyYjVu0sVwMyhlS+o7AhqdtETRMNI1553sBt8 X-Received: by 2002:a17:902:88:: with SMTP id a8-v6mr10162312pla.156.1532011348901; Thu, 19 Jul 2018 07:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532011348; cv=none; d=google.com; s=arc-20160816; b=wRZymz8sA1c4O0zPxFzSyB9p26x8qcAy1mv9MP4T73I3USHPQm1us06cP+0dW8JGcx L4tgAX4dT85jVCKIRKWqB54IetVSROqCz8kVYI0cC+7ZefJkg8Gn9C5zQwMLqLS+eHAW qoH3+jPIIUXa+uW8mxMh0YxvHmz4FUid9S4DnWqFfStggRxKVmuHeAnfBt/TUbdpGnsK kD6dl0s6HMerFPWwmuIDF+i9w/AWVL89QEnd8gg2bd44PF2X+LOtRS+q6buHeWVIwyo5 Q/pjcDoH7PCJLFZDg7rW9XASSGXRsu47SU7oO9HYNaXlLJLivnwxueSmHVTA4FQNoSsm 61Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id :mime-version:references:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=Fdg8kbPsUqe4HfeHEtq1VNzPsIeC539aZDRhcYef2+g=; b=SQ4LnzfNiIZ2qNsF2sR3EielpkDXFKKjjcClu9+ywtRti/4ECiKNPOnt1k066U4ZXu zbvqi+0bCDJSilEOoomwOzBJ3Ehap28/GKMkRQBOtxJGxwpy/Gp+ZJf2chJ7DKMBMolk HUmzEKHuXXTte//hZP2SHzMsSWWjFB+uZnMVriBMAB3i2tmY18E7rQnCNgxEB0jyHq6d y4RTWa666ZmAEmcwDTLzMfxouRFrntGgtEViNPYm57TrUjSRBU2C4APVbIGHNYeRAcg7 lDSYoAfp9FjEoL6ybgiMDRUoKEWp3iC697jMyZ2L/zQvbW9sOq9WI75+fKTjf0j/mENF drIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i2-v6si5956560pgo.121.2018.07.19.07.42.14; Thu, 19 Jul 2018 07:42:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731735AbeGSPY2 (ORCPT + 99 others); Thu, 19 Jul 2018 11:24:28 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46840 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730922AbeGSPY1 (ORCPT ); Thu, 19 Jul 2018 11:24:27 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6JEcdld052452 for ; Thu, 19 Jul 2018 10:40:58 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kau5k4wae-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 19 Jul 2018 10:40:58 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Jul 2018 15:40:55 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 19 Jul 2018 15:40:53 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6JEeqd324248524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Jul 2018 14:40:52 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1EE74C040; Thu, 19 Jul 2018 17:41:09 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A36FA4C04A; Thu, 19 Jul 2018 17:41:09 +0100 (BST) Received: from mschwideX1 (unknown [9.152.212.148]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 19 Jul 2018 17:41:09 +0100 (BST) Date: Thu, 19 Jul 2018 16:40:51 +0200 From: Martin Schwidefsky To: "Gustavo A. R. Silva" Cc: Heiko Carstens , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390/tape: replace PTR_RET with PTR_ERR_OR_ZERO In-Reply-To: <20180719044653.GA24968@embeddedor.com> References: <20180719044653.GA24968@embeddedor.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18071914-0020-0000-0000-000002A8879C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071914-0021-0000-0000-000020F4FD7A Message-Id: <20180719164051.2908125c@mschwideX1> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-19_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=833 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807190157 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Jul 2018 23:46:53 -0500 "Gustavo A. R. Silva" wrote: > PTR_RET is deprecated, use PTR_ERR_OR_ZERO instead. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/s390/char/tape_class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/char/tape_class.c b/drivers/s390/char/tape_class.c > index e403edf..b58df0d 100644 > --- a/drivers/s390/char/tape_class.c > +++ b/drivers/s390/char/tape_class.c > @@ -77,7 +77,7 @@ struct tape_class_device *register_tape_dev( > tcd->class_device = device_create(tape_class, device, > tcd->char_device->dev, NULL, > "%s", tcd->device_name); > - rc = PTR_RET(tcd->class_device); > + rc = PTR_ERR_OR_ZERO(tcd->class_device); > if (rc) > goto fail_with_cdev; > rc = sysfs_create_link( Applied to the s390/linux tree for the next merge window. Thanks. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.