Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261585AbTIRQPa (ORCPT ); Thu, 18 Sep 2003 12:15:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261641AbTIRQPa (ORCPT ); Thu, 18 Sep 2003 12:15:30 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:1801 "EHLO mail.parknet.co.jp") by vger.kernel.org with ESMTP id S261585AbTIRQP3 (ORCPT ); Thu, 18 Sep 2003 12:15:29 -0400 To: Andries Brouwer Cc: Norman Diamond , linux-kernel@vger.kernel.org, Vojtech Pavlik Subject: Re: 2.6.0-test5 vs. Japanese keyboards [3] References: <1b7301c37a73$861bea70$2dee4ca5@DIAMONDLX60> <20030914122034.C3371@pclin040.win.tue.nl> <206701c37ab2$6a8033e0$2dee4ca5@DIAMONDLX60> <20030916154305.A1583@pclin040.win.tue.nl> <87vfrr3851.fsf@devron.myhome.or.jp> <20030917192216.A2164@pclin040.win.tue.nl> From: OGAWA Hirofumi Date: Fri, 19 Sep 2003 01:15:09 +0900 In-Reply-To: <20030917192216.A2164@pclin040.win.tue.nl> Message-ID: <8765jqt6nm.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 30 Andries Brouwer writes: > On Wed, Sep 17, 2003 at 09:35:22PM +0900, OGAWA Hirofumi wrote: > > Andries Brouwer writes: > > > > > > > OGAWA Hirofumi posted a patch for the yen-sign pipe key on 2003.07.23 > > > > > for test1 but his patch still didn't get into test3. > > > > until 2.4 the value of NR_KEYS was 128, while 2.6 uses 256 > > > in input.h > > #define KEY_MAX 0x1ff > > in keyboard.h > > #define NR_KEYS (KEY_MAX+1) > > > > NR_KEYS is 512... Or we should use 256, you mean? > > Yes, I think so. > > Maybe Vojtech can tell us why he wrote 512, but I just see a > large amount of wasted space (and, as you already pointed out, > the need for new ioctls) if one uses 512. > > As far as I can see, everything works with 256. > Indeed, everything seems to assume 256. That sounds good to me. Vojtech, did we need NR_KEYS(KEY_MAX?) greater than 256? -- OGAWA Hirofumi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/