Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1849786imm; Thu, 19 Jul 2018 08:50:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpexoe7MsPjw5ZaEAlttvJnOSfELN4rhZRvc2jqfivqkr0YT7ja6EmYBzOSi1HYFExAJVwbW X-Received: by 2002:a62:e30c:: with SMTP id g12-v6mr10160066pfh.25.1532015449011; Thu, 19 Jul 2018 08:50:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532015448; cv=none; d=google.com; s=arc-20160816; b=aQjQ6lyRlYDjo9a3lHZ5HqpJbBHb7j9HgqLMjBog6UGOkVxrmF69Oa219WClcMQfSk NLfLtv/cke9MOufYgToLwFjXafxtPY6hUYVYkctiQFJ24Qp+MxWXmUdgQ2FnOZ83ndtg EQ+4ORi5aISnDSGaJNwHRtwYPSyevmqP92O9EbEa16IsVzVq0/fbXbgVctrr0LdA/0js je8jDue1b5LG8Hr3p38pItdtlhPEkwqY5Q26o8IsxKU0nZcJIUvAgWcnMucxr7kZrAsJ Rv0G6AHqO/a5pBIIeqCYiAUQ8NqJx5Fm82GvPsg9Vq6pVU/4ZT5rUCoNaehdb8FrwBmo GliQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=UVoOARMZrx+tf6lEKrpQfLfI77awjkCOjAfulumGcdg=; b=X6xC7D/UgZW3NNSFrDjpdiIb/5iDNlAb9dkcx5FMDt84CG5qOoIU569IZopJre7IAK cqm+59EuZRvG8eqxW6cFImeEGHjGrrwwmVQGIAQeQI85EoJ2KnyIdS4rK9yVax3T9WhK oRTEYuBjNZBfeeJbhRCM26NzRrgiGkovyg6DwAa83ChIjo7QnfY8gY2bKQGAeQprjoIa +wDDSS0RTPcGqJj3P/bO/e2dPsBLIWYwIlAuHCNwODMZ0wqyUR3flvH23vOBe9e8iisW 3ACoGU1dWogeAF/BY8NQ5z63qr63axrbxg93aqiM+DPnYpV43Cmt+iqTL5S8qkiXCDWd OK/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=ROkreOhr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2-v6si5615020plh.136.2018.07.19.08.50.34; Thu, 19 Jul 2018 08:50:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=ROkreOhr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732007AbeGSQdL (ORCPT + 99 others); Thu, 19 Jul 2018 12:33:11 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:55282 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731894AbeGSQdK (ORCPT ); Thu, 19 Jul 2018 12:33:10 -0400 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6JFmK09025758; Thu, 19 Jul 2018 08:48:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=facebook; bh=UVoOARMZrx+tf6lEKrpQfLfI77awjkCOjAfulumGcdg=; b=ROkreOhr8LXoNMXN/3xEDTwu2nnfwghrcx8BfGlD7DYo0ehh1qG3mpI4Xilto3ESy51r d5m5JwaRYmr4UeumOJv7LOCR41q1yCgDfuAK5AScXn3gCex1K6dDN/jtolrQZVUK+SMI Sgp4CcYZiCMDGx5T6JQj4kNNmukIioh2lww= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 2kaf14hv9f-12 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 19 Jul 2018 08:48:39 -0700 Received: from kafai-mbp.dhcp.thefacebook.com (192.168.52.123) by mail.thefacebook.com (192.168.16.15) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 19 Jul 2018 08:48:18 -0700 Date: Thu, 19 Jul 2018 08:48:17 -0700 From: Martin KaFai Lau To: YueHaibing CC: , , , Subject: Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument types Message-ID: <20180719154817.ycwupljsx4ghkhom@kafai-mbp.dhcp.thefacebook.com> References: <20180719075659.9800-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180719075659.9800-1-yuehaibing@huawei.com> User-Agent: NeoMutt/20180512 X-Originating-IP: [192.168.52.123] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-19_06:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote: > Fix following warning: > net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type > net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type > > Signed-off-by: YueHaibing LGTM. Missing a Fixes tag though. Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module") Acked-by: Martin KaFai Lau