Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument
 types
To:     Martin KaFai Lau <kafai@fb.com>, YueHaibing <yuehaibing@huawei.com>
Cc:     ast@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
References: <20180719075659.9800-1-yuehaibing@huawei.com>
 <20180719154817.ycwupljsx4ghkhom@kafai-mbp.dhcp.thefacebook.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <9c9f981b-7d1e-1bb2-6771-727fc762c7c5@iogearbox.net>
Date:   Thu, 19 Jul 2018 17:51:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20180719154817.ycwupljsx4ghkhom@kafai-mbp.dhcp.thefacebook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/19/2018 05:48 PM, Martin KaFai Lau wrote:
> On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote:
>> Fix following warning:
>> net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type
>> net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> LGTM.  Missing a Fixes tag though.
> 
> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
> Acked-by: Martin KaFai Lau <kafai@fb.com>

(Should go to -net tree.)

Acked-by: Daniel Borkmann <daniel@iogearbox.net>