Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2088959imm; Thu, 19 Jul 2018 13:01:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfhAwPnk+O96p37Wn25fQDS+ybrfWWqdWfthYKO1qvRA2gHKJ8vnu2JjR6alCy5MXJb+deO X-Received: by 2002:a62:e106:: with SMTP id q6-v6mr11002278pfh.75.1532030477566; Thu, 19 Jul 2018 13:01:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532030477; cv=none; d=google.com; s=arc-20160816; b=svWorLX/SV8tA7+GLMLmDr18J+yQyt7G1zKNFhIwxjeIOJbuKz2xpd2vP3VOf4oUxf IpuRPyx/KryN8hpayPxGxVmtwPUna9aQ8Up6HErOtumcH5WGZLJDip0g2cZAmv73LZn+ oRjuFJwPduSmDHCt5N4F0aysW2QQrEjtCY4K/pl7NnQJhrePV/6gWPgcpj6MSRKDRTJE uCVDtqXwM9n6Jv5HGKUKytOyOEf0zgfo46R9BDrIlD8xxlfhzyOxUfjdNEtXztiYY22N ZUiwKQa+zH14JykEq5mEmYxhO4JDMBLIDVQKPU/LLBtRGZmx39ePG9NjNN1nM7vcm8Nh Z3fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=I75kxmBTru1UzX2PQRe3XdnyeGupJQzpnNNYnAgGGLg=; b=Re6ZLaKDuVLDssAGweDB1CXyWf7GzNwaQDq26gd5rGwct3GX4Zg20zV7GUZ4GcM9Y3 ban9TssOrlkzxv/SGVxhlWsT7zYAycmNwcRqJvGvK5iayAUV7PQboiZetQEFecM6xKpG cXbgmS15oxBZ5kcpLxLW6iZGzmyR195Dx3xeCBHY1XBBwL62xSqS/PyqiSAPjc0HcUqK V3uPL4olisnmbERJDDeFZVMpFLmfHZMbwqMd1gsrmKyGcmut9qduatH4lKqaJo2LyEMp uYFnepmZ0rrk54ca1lQV12dPqbqtJyTSFmJ3LiP0Y7g3I3KojEnNQ17kwcVKpIJ/+a+X YBhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=ZS9Et4pU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12-v6si31155pgh.264.2018.07.19.13.01.02; Thu, 19 Jul 2018 13:01:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=ZS9Et4pU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730315AbeGSUoz (ORCPT + 99 others); Thu, 19 Jul 2018 16:44:55 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:44071 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727555AbeGSUoz (ORCPT ); Thu, 19 Jul 2018 16:44:55 -0400 Received: by mail-pg1-f196.google.com with SMTP id r1-v6so4694108pgp.11 for ; Thu, 19 Jul 2018 13:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id; bh=I75kxmBTru1UzX2PQRe3XdnyeGupJQzpnNNYnAgGGLg=; b=ZS9Et4pUmgr/FSYDih5UtMKXideAWa8ZeeI8iZXwv4CkaWbVjAOpQPTXjsZKoCohLu yHVfxxdwLa5GnVaVSxD+zbQ+Dfxrt0sVMcMvC31hM+zssmJDvfLYkhDxQTgD3k8MxuUj K1usnZ4X8HrlucJLz7i4heVgB+uxsbVbV/xao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=I75kxmBTru1UzX2PQRe3XdnyeGupJQzpnNNYnAgGGLg=; b=VAkxqDywyxD7Rc2VuscyDKr1SRy41Savppg2gpP6n+fI6vVyqb2brmDgSgMbg+vgKz 5MPfv0VtO8EtByHlTh/N/EAgtpfRh0uwrWusp8PGy2qBfaJJMfZDFgBmfrwtMNVeQdPZ myxxFjVGllQzrn3rhad4zbsoPuXm+cWmqPGDpDZjsjTvv1jXfVEjXuuC7YxwQRx2C90P sH/bssYjoyUYuVGe8RTwH21+ELUF6InNsWfJcJXU1xhZBXvzG0mVpy51l0aHyCutGPcg vsWXI1nvGluUVFTeLJsulQLTZ9cklkQ/yHq1kt5ggRe0/JkcYWBT4GNigDjoZ1P8SvOK x+Gw== X-Gm-Message-State: AOUpUlF2vwBUOGTwmNlvZvhMkiBXN5fQE5cvVH3bGkteHv49nhJdnMVQ GktRiTBV2XF/z78/HWpR2zheRNNRbXc= X-Received: by 2002:a62:f0d:: with SMTP id x13-v6mr10777303pfi.123.1532030415613; Thu, 19 Jul 2018 13:00:15 -0700 (PDT) Received: from joelaf.mtv.corp.google.com ([2620:0:1000:1600:3122:ea9c:d178:eb]) by smtp.gmail.com with ESMTPSA id x4-v6sm15379pfm.119.2018.07.19.13.00.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jul 2018 13:00:15 -0700 (PDT) From: Joel Fernandes To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Ruchi Kandoi , Joel Fernandes , Ingo Molnar , Jonathan Corbet , linux-doc@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Steven Rostedt , Viresh Kumar Subject: [PATCH RFC] cpufreq: trace frequency limits change Date: Thu, 19 Jul 2018 12:59:57 -0700 Message-Id: <20180719195957.59000-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.18.0.203.gfac676dfb9-goog Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ruchi Kandoi systrace used for tracing for Android systems has carried a patch for many years in the Android tree that traces when the cpufreq limits change. With the help of this information, systrace can know when the policy limits change and can visually display the data. Lets add upstream support for the same. Signed-off-by: Ruchi Kandoi Signed-off-by: Joel Fernandes (Google) --- Documentation/trace/events-power.rst | 1 + drivers/cpufreq/cpufreq.c | 1 + include/trace/events/power.h | 25 +++++++++++++++++++++++++ 3 files changed, 27 insertions(+) diff --git a/Documentation/trace/events-power.rst b/Documentation/trace/events-power.rst index a77daca75e30..2ef318962e29 100644 --- a/Documentation/trace/events-power.rst +++ b/Documentation/trace/events-power.rst @@ -27,6 +27,7 @@ cpufreq. cpu_idle "state=%lu cpu_id=%lu" cpu_frequency "state=%lu cpu_id=%lu" + cpu_frequency_limits "min=%lu max=%lu cpu_id=%lu" A suspend event is used to indicate the system going in and out of the suspend mode: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index b0dfd3222013..6533c6987866 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2236,6 +2236,7 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, policy->min = new_policy->min; policy->max = new_policy->max; + trace_cpu_frequency_limits(policy->max, policy->min, policy->cpu); policy->cached_target_freq = UINT_MAX; diff --git a/include/trace/events/power.h b/include/trace/events/power.h index 908977d69783..e978b05b0200 100644 --- a/include/trace/events/power.h +++ b/include/trace/events/power.h @@ -148,6 +148,31 @@ DEFINE_EVENT(cpu, cpu_frequency, TP_ARGS(frequency, cpu_id) ); +TRACE_EVENT(cpu_frequency_limits, + + TP_PROTO(unsigned int max_freq, unsigned int min_freq, + unsigned int cpu_id), + + TP_ARGS(max_freq, min_freq, cpu_id), + + TP_STRUCT__entry( + __field(u32, min_freq) + __field(u32, max_freq) + __field(u32, cpu_id) + ), + + TP_fast_assign( + __entry->min_freq = min_freq; + __entry->max_freq = max_freq; + __entry->cpu_id = cpu_id; + ), + + TP_printk("min=%lu max=%lu cpu_id=%lu", + (unsigned long)__entry->min_freq, + (unsigned long)__entry->max_freq, + (unsigned long)__entry->cpu_id) +); + TRACE_EVENT(device_pm_callback_start, TP_PROTO(struct device *dev, const char *pm_ops, int event), -- 2.18.0.203.gfac676dfb9-goog