Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] security: export security_kernel_load_data to fix
 firmware_loader build
To:     Mimi Zohar <zohar@linux.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org>
 <1532039957.4196.2.camel@linux.ibm.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <41df8eb0-865f-3e53-eb13-cde642396cf7@infradead.org>
Date:   Thu, 19 Jul 2018 15:40:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1532039957.4196.2.camel@linux.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/19/2018 03:39 PM, Mimi Zohar wrote:
> Thanks, Randy.
> 
> On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
>> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:
>>
>> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: James Morris <jmorris@namei.org>
>> Cc: "Serge E. Hallyn" <serge@hallyn.com>
>> Cc: linux-security-module@vger.kernel.org
>> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
>> ---
>>  security/security.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20180717.orig/security/security.c
>> +++ linux-next-20180717/security/security.c
>> @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
>>  		return ret;
>>  	return ima_load_data(id);
>>  }
>> +EXPORT_SYMBOL_GPL(security_kernel_load_data);
> 
> Arnd Bergmann already posted a similar patch, which is now staged in
> James' tree.
> 
> Mimi

Good.  Thanks.

-- 
~Randy