Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2289978imm; Thu, 19 Jul 2018 17:26:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcz38gAwL3EZ5jdmYLH+LvODltlYskX3kFqDV/isaLfwPECDjynZag2BCZQGQ3wnyTom79Y X-Received: by 2002:a62:404e:: with SMTP id n75-v6mr11601203pfa.232.1532046366712; Thu, 19 Jul 2018 17:26:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532046366; cv=none; d=google.com; s=arc-20160816; b=iU6YF53u3tfCo1XiOKZUG0s3PUuuNDW4NwpOvM8YZggT8wMW/NHfiRyhyiOvPvyIrx 8TL5HDbBCG54gnDBN27cZvENEy1kusgtkbj2hxKAdLkfW14n3wGwvu/oSnjmJLaos56C U2XtvQrpNezZhw9fGPfrUaHESHPsqpDhLGALtyFAgh4gih+E9Jwz0blgzXs9F2yim9rY dF6tRLJ95P0UCb9ZydzGcDu24G1rebu7A7f7gH35CyH3CRvzvbYtlxkBbSZ7trbV3S4w PXd9I/l1sXZQu60B36UaJaIQ8QYZ+Wvu+j8Xcix1vFt6QBQTBpfdMqMEjO72dbVwv9dG K6iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=3oVAMJUM5Zjf++w+a0YASj08fnYMlMrMdcQlU1D95NY=; b=JrCkpYwz9lKVYWFdxukpkdpLgpqBRO68VewV1x73GcbmVIUD75JenNew+GPyM9BZZQ RDwwCShfBZZzlUL2YFu4yB5NIGB0N0zESbkXCZVprMANnTmvzR7HeVGmoeoTo7rXGZkm yHM8K5EowkVssZU0QFDl1tAggXecIWkb/HOoXQdo3SiQkFhMa/MhdlFoHyKCTC8T4WYP b3YIrAdYtKik2Jw3+Ax8wYHQdoJNYzNOhUPN6ADA5/f0kXa4js+g0fSb9FfcscLyfi5B Yo5Yp1eSzspoydxV1g49xQW4/JB5lWeSPyoCc76DsLvkHeCH9cTcQccxFqfnMs5Pgghp Px6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gQS3n+aU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q16-v6si419867pls.404.2018.07.19.17.25.50; Thu, 19 Jul 2018 17:26:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gQS3n+aU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730798AbeGTBKt (ORCPT + 99 others); Thu, 19 Jul 2018 21:10:49 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:36561 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729215AbeGTBKt (ORCPT ); Thu, 19 Jul 2018 21:10:49 -0400 Received: by mail-qk0-f193.google.com with SMTP id a132-v6so5347604qkg.3; Thu, 19 Jul 2018 17:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3oVAMJUM5Zjf++w+a0YASj08fnYMlMrMdcQlU1D95NY=; b=gQS3n+aUlQuaXRBXgGarSRz1PkjVfBH3EpDvb0flwlapFrpVu9b7FooDv3e5cAtjkD OsTxxjCGC8yx6uC7I0QKQFeh2ndrnA8rL5PPpLIlEHptP0+HWu23ZFEFcdahkbcSG4go 9EqJ6vG2JPqAWf1qKMuadWTjZKKyV+9hd/XyWGJJ5+CrbQCd02tvNRLF1RDt9A23avLS CCntpQ2xy3jYkkiO30F92lv5mYR26XETnGViwKqNFpCH6+IAQcPInXxSw1jCNmDqtkR4 5XNgC2EgVnSosTjAZDK+g1xudu7rmPbwIHQ0TZDSjVoMOavUciwp65F+aevdOxP8UzGe fQlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3oVAMJUM5Zjf++w+a0YASj08fnYMlMrMdcQlU1D95NY=; b=OsaHzGnA97b9/jwwWp6z/pwAls61CqikGd74nNDi1JcgPvWrMPQSkgH7wVZFRRAO4V ucNn5qTdSBQnDpkwFc9xprk4TPOScu/hJp09C3vF3e7lGMbl2Mlqz+XISWSjvQ+CwyU/ rRyt2Kn13HYe8zlG3/iYc5d9dW4MuE55oZULWb+9ve1kkT09yioU+R7yuwJk8yTTdc4U 9zvvNihLpGEkjeTD1xeycBjHS6u1EISKfZijfejyd66wFIkMeQqsuo+ujrQmStjSIvGG Zi3usupuh8D1hSbJrtwcOwziM3Z1PAse6mbQn6jDqcbhnJlmzDJXQUVTEaIXbYL0XLUg TKwg== X-Gm-Message-State: AOUpUlFVp9s9L9ijo4AVEwEUsJf0wqqP/gLgCDNCd7H6Ik9KfBxGcu2e afF7KoSCe/69t6nGfVOy15NEDdH4yhg= X-Received: by 2002:a37:b682:: with SMTP id g124-v6mr1639754qkf.237.1532046313153; Thu, 19 Jul 2018 17:25:13 -0700 (PDT) Received: from [10.0.2.15] (CPEac9e17937810-CM64777dd8e660.cpe.net.cable.rogers.com. [99.245.240.231]) by smtp.gmail.com with ESMTPSA id j86-v6sm577442qkh.60.2018.07.19.17.25.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jul 2018 17:25:12 -0700 (PDT) Subject: Re: [PATCH] rapidio: remove redundant pointer md To: Colin King , Matt Porter , linux-kernel@vger.kernel.org, Andrew Morton Cc: kernel-janitors@vger.kernel.org References: <20180711082346.5223-1-colin.king@canonical.com> From: Alexandre Bounine Message-ID: <801e392b-c5ba-2857-c0af-157c65171bfe@gmail.com> Date: Thu, 19 Jul 2018 20:25:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180711082346.5223-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Alexandre Bounine On 2018-07-11 04:23 AM, Colin King wrote: > From: Colin Ian King > > Pointer md is being assigned but is never used hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: variable 'md' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/rapidio/devices/rio_mport_cdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c > index a8cb8d2f2abb..cbe467ff1aba 100644 > --- a/drivers/rapidio/devices/rio_mport_cdev.c > +++ b/drivers/rapidio/devices/rio_mport_cdev.c > @@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg) > static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg) > { > struct mport_cdev_priv *priv; > - struct mport_dev *md; > struct rio_async_tx_wait w_param; > struct mport_dma_req *req; > dma_cookie_t cookie; > @@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg) > int ret; > > priv = (struct mport_cdev_priv *)filp->private_data; > - md = priv->md; > > if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param)))) > return -EFAULT; >