Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2503544imm; Thu, 19 Jul 2018 23:04:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdIFNsUI6z23FrCdNM+HTnHvkzLJrd/fuq7drudozZ8mSQfy5525/x5F6rdonDsOGigvFVf X-Received: by 2002:a02:5e42:: with SMTP id h63-v6mr556145jab.117.1532066691522; Thu, 19 Jul 2018 23:04:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532066691; cv=none; d=google.com; s=arc-20160816; b=px09NAPnvEf3Pmj48UgDdGS5CsRg4kBGoZb5lkz/HLhOuUIrp7nonc5nZzaDq+bFm8 VJtl7FCPMATxJ3PomyLewjlUiDHNhosf8c4rc3BSZURXpWfMdEx0txFMIG/OyvKTpTp+ VxXNPwOr5k7RCmjTeHelCu6oKwlbTpEdv8NxbN1/m0GkGnZEaMtavmb+96qv6/pPVnju N7vlJuywrW3mqshJmIexOvoZMSdvbJA8Xg5RHSM9eP6EDxGx8KaYzfplILDtP9KZ9rhv alWpuMaWsEnkFpxW1iIm5ZGAcYBblpGPXMdkJbo1FN7vu0keScVOfUuEQY1jEajAjHTv yAcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=tKS2/aiht3UPBjjBpyjX9MchVy/Pb+HrzAn3IbOUD68=; b=sjLd2kQMtFD9bmp7PGNLj+oYO30s9sDD32pX/wwh85Pig4ZQIzV4vkwXQC3ro+wLg9 2tWIdjMhdjMG1PYzbVV6AY0edTq1KwidThTHdUKHc7/qW9a4caKlpchmfueVh9My66kD Pem+jtshUjkm/JdARSVRBbjKxw+RsCzZj5AXi4flcubDXmuFF8bEclg+8PvEBzx+Fzu5 jl1rItInWAv3cK/9y36CwaaDJFKKcleOfmyCUMfjVe+WUCCyxqOvb3RJSk65F1qdhyVu Qg6i8Y7AqPFRV9OzRgYB880oc84b5AyGw5berZgOPNkVHY8gx2G5e1nZ8vVM90gU7jrG h8Aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u26-v6si834013jaa.125.2018.07.19.23.04.35; Thu, 19 Jul 2018 23:04:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727301AbeGTGtr (ORCPT + 99 others); Fri, 20 Jul 2018 02:49:47 -0400 Received: from nautica.notk.org ([91.121.71.147]:38044 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbeGTGtr (ORCPT ); Fri, 20 Jul 2018 02:49:47 -0400 Received: by nautica.notk.org (Postfix, from userid 1001) id 959DAC009; Fri, 20 Jul 2018 07:57:20 +0200 (CEST) Date: Fri, 20 Jul 2018 07:57:05 +0200 From: Dominique Martinet To: Julia Lawall Cc: Masahiro Yamada , Ville =?utf-8?B?U3lyasOkbMOk?= , Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] coccinelle: suggest replacing strncpy+truncation by strscpy Message-ID: <20180720055705.GA2810@nautica> References: <1531555951-9627-1-git-send-email-asmadeus@codewreck.org> <1532047018-23754-1-git-send-email-asmadeus@codewreck.org> <20180720054050.GA32233@nautica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall wrote on Fri, Jul 20, 2018: > On Fri, 20 Jul 2018, Dominique Martinet wrote: > > I guess there is no value in the script landing first by itself, I'll > > just remove the script path from the commit messages and resend the > > first few this weekend. > > It's not that there is no value to the script. The problem is that I > don't know if the script is correct - I'm not familiar with these string > functions. Once the script is in the kernel, it stays there beyond your > patches, so I would prefer to know that it is correct up front, rather > than having to remove it afterwards. I understand, I didn't say there is no value in the script ("landing first by itself" doesn't mean it should/can not be taken later) I'll bump this thread again in a couple of weeks after having resent most of the other patches -- Dominique Martinet