Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2531371imm; Thu, 19 Jul 2018 23:44:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcUDwQo4ZZMYxRRSNGuDi9JnySdp/fZPD7hjG82/52omtZrmcV6Gxh/n7WhyjumJQAfH6lB X-Received: by 2002:a63:4002:: with SMTP id n2-v6mr819309pga.285.1532069060028; Thu, 19 Jul 2018 23:44:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532069060; cv=none; d=google.com; s=arc-20160816; b=DGste9B6v/qLpEkMFrZkMrMyJ0wYLOVgwN2ZqrAiI35wBzqJbohHiN1PdwDbRcJnxQ HphL1Z2lC3UnbpXgvXuDb/QEim1FfY1gsZoNCcMsnlLGDx8R0cE52Mek3RSpETKxlKR4 ZGddaoS6G4xjdWaYhbIQrFXD3gh0J26GpCwi7lK2767VnIuJ2bMyvyp5tU7Hsfx3tm9u CdpFCoWsOPbA3fs9+61oK1k7+0srlJA5ci3TUVEgV7mIU4LtV4GFN65xbzD1eqWL6Rl8 SPZJoxTR7JF38grrxlOxZDeiYTYXPQ8ouP37re4D3DA2sNINeL5xY1UlKLyHof2fxnwD g/ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=0c6dtjowHPDX2nZr8+48jcCT+NR9BwijNSvS5Vkc1pA=; b=PV/o02DqNsk7CUl/vceLjZdNCsBtQ5lFsBqRIuvwmiy22kXNq/BD/BoaW3n2I6pUko FinhE0q6dVEFc+fjiJzfIXUwtEEQBa/snquyI6iPC5PH7n0W9rPn4NGjz7ByWd1qOXEs DDs+wf4yUQ4N7/mJAmZA5XHrTs6MjXqvTc8jSRfK3UNndRUifErmQ7Zmky4EBQ+jyMTU bh1g6R6WLWSXiLHPCMhF1ndQHinoHskWJkoVfu2VfhkEKGN5ldGN5n/olkWb8RlpaIFZ eWaCoEHwcH/nqX8lf2+vAjDaDyTDZ6jJPMIxJDICF7w74KejhwHtjfTcLHbyWnMiWwy7 xVGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9-v6si969251pgv.290.2018.07.19.23.44.05; Thu, 19 Jul 2018 23:44:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727133AbeGTHaN (ORCPT + 99 others); Fri, 20 Jul 2018 03:30:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:42268 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726624AbeGTHaN (ORCPT ); Fri, 20 Jul 2018 03:30:13 -0400 Received: from localhost (unknown [172.58.43.55]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6292514810848; Thu, 19 Jul 2018 23:43:30 -0700 (PDT) Date: Thu, 19 Jul 2018 23:43:29 -0700 (PDT) Message-Id: <20180719.234329.512279372120817504.davem@davemloft.net> To: neilb@suse.com Cc: herbert@gondor.apana.org.au, tgraf@suug.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH - revised] rhashtable: detect when object movement might have invalidated a lookup From: David Miller In-Reply-To: <87va9aqv05.fsf@notabene.neil.brown.name> References: <87fu0kt5m0.fsf@notabene.neil.brown.name> <20180719.051440.931407144963903326.davem@davemloft.net> <87va9aqv05.fsf@notabene.neil.brown.name> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Jul 2018 23:43:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: NeilBrown Date: Fri, 20 Jul 2018 16:30:34 +1000 > Does this ruling also apply to the bit-spin-lock changes and the > per-cpu-counter changes that I have proposed? These improve > scalability when updates dominate. Not having these in mainline > would mean I need to carry a separate rhashtables implementation for > lustre, which means code diversion which isn't healthy in the long > run. If it helps existing rhashtable users generally, then it is fine, since it will actually be tested by upstream users. Thanks.