Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] usb: xhci: Fix memory leak in xhci_endpoint_reset()
To:     iq_132@sina.com, gregkh@linuxfoundation.org
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zheng Xiaowei <zhengxiaowei@ruijie.com.cn>
References: <1531120365-44810-1-git-send-email-iq_132@sina.com>
From:   Mathias Nyman <mathias.nyman@intel.com>
Message-ID: <fec4a873-9367-9289-9e49-20cad7387f77@intel.com>
Date:   Fri, 20 Jul 2018 11:17:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1531120365-44810-1-git-send-email-iq_132@sina.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09.07.2018 10:12, iq_132@sina.com wrote:
> 
> From: Zheng Xiaowei <zhengxiaowei@ruijie.com.cn>
> 
> If td_list is not empty the cfg_cmd will not be freed,
> call xhci_free_command to free it.
> 
> Signed-off-by: Zheng Xiaowei <zhengxiaowei@ruijie.com.cn>
> ---
>   drivers/usb/host/xhci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 2f4850f..68e6132 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -3051,6 +3051,7 @@ static void xhci_endpoint_reset(struct usb_hcd *hcd,
>   	if (!list_empty(&ep->ring->td_list)) {
>   		dev_err(&udev->dev, "EP not empty, refuse reset\n");
>   		spin_unlock_irqrestore(&xhci->lock, flags);
> +		xhci_free_command(xhci, cfg_cmd);
>   		goto cleanup;
>   	}
>   	xhci_queue_stop_endpoint(xhci, stop_cmd, udev->slot_id, ep_index, 0);
> 

Thanks, adding to queue

-Mathias