Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Jul 2018 14:59:21 +0530
From:   Vinod <vkoul@kernel.org>
To:     hannah@marvell.com
Cc:     dan.j.williams@intel.com, dmaengine@vger.kernel.org,
        thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org,
        nadavh@marvell.com, omrii@marvell.com, oferh@marvell.com,
        gregory.clement@bootlin.com
Subject: Re: [PATCH 3/5] dmaengine: mv_xor_v2: convert callback to helper
 function
Message-ID: <20180720092921.GR3219@vkoul-mobl>
References: <1531823403-3683-1-git-send-email-hannah@marvell.com>
 <1531823403-3683-4-git-send-email-hannah@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1531823403-3683-4-git-send-email-hannah@marvell.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 17-07-18, 13:30, hannah@marvell.com wrote:
> From: Hanna Hawa <hannah@marvell.com>
> 
> This is in preperation of moving to a callback that provides results to the

typo preperation

> callback for the transaction. The conversion will maintain current behavior
> and the driver must convert to new callback mechanism at a later time in
> order to receive results.
> 
> Signed-off-by: Hanna Hawa <hannah@marvell.com>
> ---
>  drivers/dma/mv_xor_v2.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index e718498..14e2a7a 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -589,9 +589,8 @@ static void mv_xor_v2_tasklet(unsigned long data)
>  			 */
>  			dma_cookie_complete(&next_pending_sw_desc->async_tx);
>  
> -			if (next_pending_sw_desc->async_tx.callback)
> -				next_pending_sw_desc->async_tx.callback(
> -				next_pending_sw_desc->async_tx.callback_param);
> +			dmaengine_desc_get_callback_invoke(
> +					&next_pending_sw_desc->async_tx, NULL);
>  
>  			dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
>  		}

-- 
~Vinod